Trivial cleanups in full_stack_target/fuzztarget#285
Merged
TheBlueMatt merged 4 commits intolightningdevkit:masterfrom Jan 16, 2019
Merged
Trivial cleanups in full_stack_target/fuzztarget#285TheBlueMatt merged 4 commits intolightningdevkit:masterfrom
TheBlueMatt merged 4 commits intolightningdevkit:masterfrom
Conversation
Note that there doesn't appear to be a way to conditionally set #[no_main] so that has to happen manually at compile-time.
ariard
reviewed
Jan 16, 2019
ariard
left a comment
ariard
left a comment
There was a problem hiding this comment.
utACK, enabling libfuzzer by default in travis builds would be too time expensive or doesn't make sense ?
Collaborator
Author
|
We currently only run honggfuzz on Travis, not even AFL. We could run more but the point of Travis fuzz runs is to catch obvious errors not to do a thorough test.
… On Jan 15, 2019, at 20:24, ariard ***@***.***> wrote:
@ariard commented on this pull request.
utACK, enabling libfuzzer by default in travis builds would be too time expensive or doesn't make sense ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New comments, libfuzzer "support", don't compile some unused stuff in utils.