Upgrade to secp256k1 v12, bitcoin v16, and crates bitcoin_hashes#294
Merged
TheBlueMatt merged 3 commits intolightningdevkit:masterfrom Jan 22, 2019
Merged
Conversation
TheBlueMatt
force-pushed
the
2019-01-deps-bump
branch
from
b828208 to
946b89f
Compare
TheBlueMatt
force-pushed
the
2019-01-deps-bump
branch
from
8b98ace to
946b89f
Compare
Hashes cant be all-0s, so we can normally unwrap, but fuzztarget can generate all-0 hashes, so we have to handle it and swap for something else.
TheBlueMatt
force-pushed
the
2019-01-deps-bump
branch
from
946b89f to
8678bda
Compare
Collaborator
Author
|
Gonna go ahead and take this. Sadly implies a rebase for a few things but I dont want it to sit forever. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll rebase the #286, #288, #290 stack on top of this in a bit.