Stop using a constant for monitor update_ids after closure#3355
Merged
TheBlueMatt merged 8 commits intolightningdevkit:mainfrom Nov 14, 2024
Merged
Stop using a constant for monitor update_ids after closure#3355TheBlueMatt merged 8 commits intolightningdevkit:mainfrom
update_ids after closure#3355TheBlueMatt merged 8 commits intolightningdevkit:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sadly, this requires some very annoying upgrade semantics - users cannot upgrade directly from 0.0.123 and earlier to 0.1 as long as they have pending forwarded HTLCs which have not yet been resolved. Instead, all HTLCs must be resolved (and any new HTLCs must have been forwarded using LDK 0.0.124) prior to the upgrade. I'm not particularly happy about this, but in practice I think its okay - those using LDK with forwarding are generally pretty active and upgrade quickly, or at least have the engineering chops to figure out the upgrade pattern (and could backport the inclusion of
counterparty_node_idin HTLC forwarding).