Introduce Flow utilities and OffersMessageFlow implementation#3639
Merged
valentinewallace merged 6 commits intolightningdevkit:mainfrom Jun 2, 2025
Merged
Introduce Flow utilities and OffersMessageFlow implementation#3639valentinewallace merged 6 commits intolightningdevkit:mainfrom
valentinewallace merged 6 commits intolightningdevkit:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR presents an alternative approach to #3412.
It introduces the
Flowtrait and its implementation,OffersMessageFlow, as a mid-level API that abstracts most Offers-related logic out ofChannelManager, while allowingChannelManagerto be parameterized overFlow.This improves modularity and separation of concerns, making the Offers-related code more maintainable. Additionally, it provides a set of functional utilities for users who do not use
ChannelManagerin their workflow.