Move remote htlc transactions signature behind signer interface#561
Closed
ariard wants to merge 7 commits intolightningdevkit:masterfrom
Closed
Move remote htlc transactions signature behind signer interface#561ariard wants to merge 7 commits intolightningdevkit:masterfrom
ariard wants to merge 7 commits intolightningdevkit:masterfrom
Conversation
Author
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
==========================================
- Coverage 91.10% 91.08% -0.02%
==========================================
Files 34 34
Lines 20447 20524 +77
==========================================
+ Hits 18628 18695 +67
- Misses 1819 1829 +10
Continue to review full report at Codecov.
|
added 7 commits
April 27, 2020 19:01
…TxCache Used in next commits to avoid passing script between ChannelMonitor and OnchainTxHandler. ChannelMonitor duplicata will be removed in future commits.
As we can't predict if any and which revoked commitment tx is going to appear onchain we have by design to cache all htlc information to regenerate htlc script if needed.
As we cache more and more transaction elements in OnchainTxHandler we should dry up completly InputMaterial until them being replaced directly by InputDescriptor
By moving script generation inside OnchainTxHandler, we may dry-up further ChannelMonitor in next commits.
OnchainTxHandler By moving script generation inside OnchainTxHandler, we may dry-up further ChannelMonitor in next commits
Author
|
Closed by #610 |
1 similar comment
Author
|
Closed by #610 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build on top of #559 + #560