pwm: atmel-hlcdc: Fix frequency output being half of expected#5
Closed
kay54068 wants to merge 10000 commits intolinux4microchip:linux-6.6-mchpfrom
Closed
pwm: atmel-hlcdc: Fix frequency output being half of expected#5kay54068 wants to merge 10000 commits intolinux4microchip:linux-6.6-mchpfrom
kay54068 wants to merge 10000 commits intolinux4microchip:linux-6.6-mchpfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The atmel-hlcdc PWM driver generates an output frequency that is
exactly half of the value requested in the device tree. For example,
a request for 1000 Hz results in a 500 Hz output.
This is caused by an incorrect prescaler calculation. The driver's
formula for the clock divider did not match the hardware, which uses
a division factor of 2^(pres + 1). The driver was missing the "+1",
causing the output period to be doubled.
This patch corrects the calculation to
2^(pres + 1), aligning itwith the hardware's behavior and ensuring the generated frequency is
correct.