Skip to content

Address browser test review fixes#10

Merged
KSemenenko merged 1 commit intomainfrom
codex/remove-obs-go-live-streaming-modules
Apr 2, 2026
Merged

Address browser test review fixes#10
KSemenenko merged 1 commit intomainfrom
codex/remove-obs-go-live-streaming-modules

Conversation

@KSemenenko
Copy link
Copy Markdown
Member

Summary

  • make the recording file harness advance even when requestVideoFrameCallback never fires
  • cap the Learn startup trace RAF loop without the extra pass
  • record the current workspace-only branch workflow preference in AGENTS

Verification

  • dotnet test tests/PrompterOne.App.UITests/PrompterOne.App.UITests.csproj --filter "FullyQualifiedName=PrompterOne.App.UITests.GoLiveShellSessionFlowTests.GoLivePage_StartRecording_FilePickerSave_ProducesDecodableProgramVideoAndAudio"
  • dotnet test tests/PrompterOne.App.UITests/PrompterOne.App.UITests.csproj --filter "FullyQualifiedName=PrompterOne.App.UITests.LearnStartupAlignmentTests.LearnScreen_DemoStartup_HidesFocusRowUntilOrpLayoutIsReady" --no-build
  • dotnet build PrompterOne.slnx -warnaserror
  • dotnet test PrompterOne.slnx
  • dotnet format PrompterOne.slnx
  • dotnet build PrompterOne.slnx -warnaserror
  • dotnet test PrompterOne.slnx

Copilot AI review requested due to automatic review settings April 2, 2026 20:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens up a couple of flaky browser-driven UI test harness behaviors and records an agent workflow preference, improving reliability of Playwright-based verification in the PrompterOne UI test suite.

Changes:

  • Update the recording file harness to advance on a timeout when requestVideoFrameCallback is unavailable or never fires.
  • Fix the Learn startup trace sampling loop to cap the RAF passes without an extra iteration.
  • Document a preference to work on the active workspace branch rather than using temporary worktrees by default.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/PrompterOne.App.UITests/Media/recording-file-harness.js Makes frame-wait logic progress even when requestVideoFrameCallback doesn’t fire, reducing test hangs/flakiness.
tests/PrompterOne.App.UITests/Learn/LearnStartupAlignmentTests.cs Adjusts RAF pass counting to avoid an extra capture pass and better honor the max-pass cap.
AGENTS.md Adds guidance about avoiding throwaway worktrees/copies when the current workspace branch is available.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@KSemenenko KSemenenko merged commit 60a4779 into main Apr 2, 2026
4 of 5 checks passed
@KSemenenko KSemenenko deleted the codex/remove-obs-go-live-streaming-modules branch April 2, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants