Skip to content

Include challenge preferredTags and preferredReviewTags to tests #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ljdelight merged 1 commit into from
Oct 15, 2023
Merged

Include challenge preferredTags and preferredReviewTags to tests #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/integrationTest/java/org/maproulette/client/api/ChallengeAPIIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,9 @@ private void compareChallenges(final Challenge challenge1, final Challenge chall
Assertions.assertEquals(challenge1.getDefaultBasemap(), challenge2.getDefaultBasemap());
Assertions.assertEquals(challenge1.getDefaultBasemapId(), challenge2.getDefaultBasemapId());
Assertions.assertEquals(challenge1.getCustomBasemap(), challenge2.getCustomBasemap());
Assertions.assertEquals(challenge1.getPreferredTags(), challenge2.getPreferredTags());
Assertions.assertEquals(challenge1.getPreferredReviewTags(),
challenge2.getPreferredReviewTags());
}

private Challenge getBasicChallenge()
Expand Down
7 changes: 7 additions & 0 deletions src/test/java/org/maproulette/client/serializer/ChallengeSerializationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ public void fullSerializationTest() throws IOException
.customBasemap("customBaseMap").defaultBasemap(23)
.defaultBasemapId("defaultBaseMap").defaultPriority(ChallengePriority.LOW)
.defaultZoom(17).difficulty(ChallengeDifficulty.EXPERT).enabled(true).featured(true)
.preferredTags("#tag1,#tag2").preferredReviewTags("#reviewTag1,#reviewTag2")
.id(1234L).maxZoom(2).minZoom(3).build();

final var serializedString = this.mapper.writeValueAsString(full);
Expand All @@ -64,6 +65,9 @@ public void fullSerializationTest() throws IOException
Assertions.assertEquals(full.getMaxZoom(), deserializedChallenge.getMaxZoom());
Assertions.assertEquals(full.getMinZoom(), deserializedChallenge.getMinZoom());
Assertions.assertEquals(full.getParent(), deserializedChallenge.getParent());
Assertions.assertEquals(full.getPreferredTags(), deserializedChallenge.getPreferredTags());
Assertions.assertEquals(full.getPreferredReviewTags(),
deserializedChallenge.getPreferredReviewTags());
}

@Test
Expand Down Expand Up @@ -177,6 +181,9 @@ public void serializationTest() throws Exception
Assertions.assertNotNull(deserializedChallenge.getMediumPriorityRule());
Assertions.assertEquals(mediumPriority, deserializedChallenge.getMediumPriorityRule());
Assertions.assertEquals(lowPriority, deserializedChallenge.getLowPriorityRule());
Assertions.assertEquals("#tag1,#tag2", deserializedChallenge.getPreferredTags());
Assertions.assertEquals("#reviewTag1,#reviewTag2",
deserializedChallenge.getPreferredReviewTags());
}

/**
Expand Down
4 changes: 3 additions & 1 deletion src/test/resources/challenges/testChallenge.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,7 @@
]
}
]
}
},
"preferredTags": "#tag1,#tag2",
"preferredReviewTags": "#reviewTag1,#reviewTag2"
}