Add application service support to blueprints#74
Merged
Conversation
Split out from #68
MadLittleMods
force-pushed
the
eric/appservice-support
branch
from
79216e5 to
cf4d8e9
Compare
MadLittleMods
commented
Feb 22, 2021
MadLittleMods
commented
Feb 22, 2021
11 tasks
kegsay
reviewed
Feb 22, 2021
kegsay
reviewed
Feb 22, 2021
kegsay
reviewed
Feb 22, 2021
kegsay
reviewed
Feb 22, 2021
kegsay
reviewed
Feb 22, 2021
kegsay
reviewed
Feb 22, 2021
kegsay
reviewed
Feb 22, 2021
internal/docker/builder.go
Outdated
| var buf bytes.Buffer | ||
| tw := tar.NewWriter(&buf) | ||
| err = tw.WriteHeader(&tar.Header{ | ||
| Name: fmt.Sprintf("/appservices/%s.yaml", asID), |
Member
There was a problem hiding this comment.
Please can we do filepath escapes here, as I would like to in the future allow untrusted Blueprint input.
Collaborator
Author
There was a problem hiding this comment.
I assume you mean using client.GjsonEscape?
Member
There was a problem hiding this comment.
I mean path escaping so you can't have an asID like ../../../etc/passwd
kegsay
approved these changes
Feb 22, 2021
Member
kegsay
left a comment
kegsay
left a comment
There was a problem hiding this comment.
Love it, just a few minor issues to resolve!
- Seems like the `Volumes` syntax is to create an anonymous volume, https://stackoverflow.com/a/58916037/796832 - And lots of people not knowing what `Volumes` syntax is or what to do. Seems like Mounts is the thing to use - fsouza/go-dockerclient#155 - https://stackoverflow.com/questions/55718603/golang-docker-library-mounting-host-directory-volumes - https://stackoverflow.com/questions/48470194/defining-a-mount-point-for-volumes-in-golang-docker-sdk
MadLittleMods
force-pushed
the
eric/appservice-support
branch
from
5ca8a8a to
1b19990
Compare
MadLittleMods
commented
Feb 22, 2021
Member
|
LGTM |
Collaborator
Author
|
Woot! Thanks for the review @kegsay 🐊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add application service support to blueprints
as_tokento interact with the homserver APInamespacespart of the app service registration configURLSplit out from #68