Add default validation for unique server names#487
Merged
mattpolzin merged 5 commits intomattpolzin:mainfrom Mar 26, 2026
Merged
Add default validation for unique server names#487mattpolzin merged 5 commits intomattpolzin:mainfrom
mattpolzin merged 5 commits intomattpolzin:mainfrom
Conversation
mattpolzin
requested changes
Mar 23, 2026
Owner
mattpolzin
left a comment
There was a problem hiding this comment.
The validation and tests look good, but we can introduce less new code by using an existing helper on the Document value.
75c91a8 to
5f3df17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #467
Summary
Testing
swift test --filter BuiltinValidationTests, but SwiftPM dependency fetches timed out in this environment