Add URI resolution helpers for base URI resolution#489
Add URI resolution helpers for base URI resolution#489ayushshrivastv wants to merge 7 commits intomattpolzin:mainfrom
Conversation
|
Implementation notes for reviewers:
Files with the main implementation:
Local verification run on this branch:
|
|
Follow-up for the failing Additional local verification after the follow-up commit:
|
mattpolzin
left a comment
There was a problem hiding this comment.
Were these changes generated by an LLM? I ask because there are places where decoding of the same property is being done twice and in one of the two locations, the strategy being used does not fit the patterns established in this codebase.
If this PR was hand written, I am happy to walk through what I mean. However, if this PR was generated code that has not been read and understood by a human, I would request that you spend the time to work through this code on your own and attempt to spot the problem and gain further understanding of the codebase.
|
I put this change together myself while tracing through the existing code and validating it locally. Also I have used Codex at times to help work through failing test cases, but I still verify the changes myself before committing them. Your comment makes it clear that I’ve missed an inconsistency in how this part should be handled, so I’m going to revisit it carefully and align it with the patterns already used in the codebase before I push an update. For context, I’ve contributed to this project before and have had a couple of PRs merged, including #405 and #404. I’ve also been keeping notes here: OpenAPI Integration with DocC. |
|
I went back through the PR again and tightened the remaining pieces to stay aligned with the existing patterns in the codebase. In particular, $id now goes only through the existing CoreContext decoding path, and I cleaned up the schema accessor/initializer usage so it follows the same style already used in main rather than introducing a separate approach. I also reverted the async workaround changes, so this PR no longer changes the existing concurrency behavior in DereferencedPathItem. |
Summary
Closes #439.
Testing