fix: wrap dequantize_row_i2_s to_float callback to fix UB on ARM#469
Open
Mindev27 wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: wrap dequantize_row_i2_s to_float callback to fix UB on ARM#469Mindev27 wants to merge 1 commit intomicrosoft:mainfrom
Mindev27 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
to_floatcallback forGGML_TYPE_I2_Scastsdequantize_row_i2_stoggml_to_float_t, but the function signatures do not match. As a result,i2_scaleis never passed and ARM reads garbage from the register.This PR adds a wrapper that extracts
i2_scalefrom the tensor data and passes it correctly.Based on analysis by @betovildoza in #468. Tested build on M4 Pro; no regression observed on the dotprod path
The change is inside the vendored llama.cpp submodule, so the diff won't show on GitHub. Checkout the branch to review, or see below:
Partially addresses #468