Improve InstrumentRef parameter#7922
Draft
jenshnielsen wants to merge 3 commits intomicrosoft:mainfrom
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7922 +/- ##
==========================================
- Coverage 70.30% 69.32% -0.98%
==========================================
Files 333 333
Lines 32401 32401
==========================================
- Hits 22778 22462 -316
- Misses 9623 9939 +316 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
This requires changing |
Support looking up any Instrument as long as the name is known, not just the same as the bound instrument
jenshnielsen
force-pushed
the
instrument_ref_param_cleanup
branch
from
6affab6 to
9488fc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support looking up any Insturment as long as the name is know not just the same as the bound instrument