Fetch web api descriptions from MDN#625
Merged
sandersn merged 1 commit intomicrosoft:masterfrom Jan 18, 2019
Merged
Conversation
sandersn
reviewed
Jan 18, 2019
|
|
||
| await interfaceNames.reduce(async (previousRequest, name) => { | ||
| // Issuing too many requests in parallel causes 504 gateway errors, so chain | ||
| await previousRequest; |
Member
There was a problem hiding this comment.
why not just make this whole thing synchronous then? (Probably because node-fetch is 500x more popular than the nearest synchronous package)
sandersn
approved these changes
Jan 18, 2019
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
One small question, but this looks so good that I am going to merge it as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: microsoft/TypeScript#26404
Add a script to fetch summary descriptions of interfaces from MDN, and add the resulting file as an input for emit.