Add override keyword#13217
Closed
pcj wants to merge 10 commits intomicrosoft:masterfrom
windward-studios:override
Closed
Add override keyword#13217pcj wants to merge 10 commits intomicrosoft:masterfrom windward-studios:override
pcj wants to merge 10 commits intomicrosoft:masterfrom
windward-studios:override
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2000
This initial commit simply introduces the keyword and performs some initial modifier flags checks. The actual checks against the inheritance chain are not implemented yet.
@RyanCavanaugh or other: Can you suggest when/where the appropriate time to perform these checks are?
No formal review required at this time (obviously), but would appreciate any strategy recommendations or other suggestions.