Fix bug: Report errors on extends expression in JS even if an @augments tag is present#18854
Merged
1 commit merged intomasterfrom Oct 2, 2017
Merged
Conversation
…ments` tag is present
a6bf41d to
bb76aa7
Compare
sandersn
reviewed
Oct 2, 2017
Member
sandersn
left a comment
There was a problem hiding this comment.
Looks good, but I'm curious — in JS, which wins, @augments or extends? Or do we issue an error if they differ? I'd say we should issue an error and then let extends win.
Author
|
The PR for |
Member
|
No, what happens for /** @augments A */
class B extends C { }shouldn't we issue an error saying that you can't inherit from both |
Author
|
See the test |
Member
|
Thanks 👍 |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sequel to #18775
Turns out
getBaseConstructorTypeOfClasswas the only place we checked theextendsexpression, so that PR turned off checking if an@augmentstag was present.It would seem neater to have a
checkExpression(baseTypeNode)call incheckClassLikeDeclaration, but that would mean we check it twice in the usual case.