Use nextToken() after parsing a tag name so we can parse type keywords#26915
Merged
3 commits merged intomasterfrom Sep 13, 2018
Merged
Use nextToken() after parsing a tag name so we can parse type keywords#269153 commits merged intomasterfrom
3 commits merged intomasterfrom
Conversation
ghost
force-pushed
the
numberKeywordInJsDoc
branch
from
a0db193 to
0e23b49
Compare
sandersn
reviewed
Sep 13, 2018
src/compiler/parser.ts
Outdated
| } | ||
|
|
||
| function skipWhitespaceOrAsterisk(): void { | ||
| function skipWhitespaceOrAsterisk(next: () => void = nextJSDocToken): void { |
Member
There was a problem hiding this comment.
I think it would be better (at least slightly) to make next required.
Author
There was a problem hiding this comment.
What about for parseJSDocIdentifierName?
sandersn
approved these changes
Sep 13, 2018
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Looks OK. Just one optional style suggestion.
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26890
Previously we would parse
numberas an Identifier, which lead to an error later. (This affected/** @type number */, not just enums.) This changes things so we usenextToken()after a jsdoc tag name.Note than during normal scanning we skip whitespace in the scanner instead of in the parser, so
scanner.getStartPos()starts at the whitespace before the token. So we now need to usegetStartPositionOfRange()to get the true start.