Convert node and symbol links into checker-local sparse arrays with per-property getters and setters#28403
Closed
weswigham wants to merge 1 commit intomicrosoft:masterfrom
Closed
Convert node and symbol links into checker-local sparse arrays with per-property getters and setters#28403weswigham wants to merge 1 commit intomicrosoft:masterfrom
weswigham wants to merge 1 commit intomicrosoft:masterfrom
Conversation
…er-property getters and setters
Member
Author
|
At least in node 9.9, it looks like this no longer helps blanket performance, just memory usage (although 3-5% memory usage improvements are pretty nice):
not really scientific since the iteration count is so low, though. Need to get the perf testing machine running again, I think. In any case, I'll try for some more stable numbers overnight. |
Member
Author
|
Yeah, the node 11 runs on windows look quite a bit like the node 9 ones. Memory improvements, but no perf change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was talking about this with @ahejlsberg the other day. Still to need rerun perf tests to verify that this still gets us some perf gains (I put up #19163 a long time ago, but we hesitated on it because the API was eh, despite the perf gains); but this API (thanks for the suggestions @ahejlsberg) is actually nicer than our older symbol links API (in addition to being monomorphic), since adding new ones is easy and doesn't require synchronizing types. I'll have some perf testing results up soon.
As an aside, while refactoring I discovered we actually had two unused
NodeLinksmembers -resolvedIndexInfoandresolvedJsxElementAllAttributesType. They are simply gone, now.