fix(helpers): Use hasOwnProperty.call#39537
Merged
Conversation
# Conflicts: # tests/baselines/reference/tsbuild/sample1/incremental-declaration-changes/when-esModuleInterop-option-changes.js # tests/baselines/reference/tsc/declarationEmit/initial-build/when-pkg-references-sibling-package-through-indirect-symlink.js
weswigham
approved these changes
Jul 10, 2020
Member
weswigham
left a comment
There was a problem hiding this comment.
Yeah, I was always confused why some helpers did use the prototype method and some did not.
Contributor
Author
|
The tslib side of this change has been merged as well. |
rimunroe
added a commit
to rimunroe/vitest-commonjs-exports-prototype-issue
that referenced
this pull request
Jan 26, 2023
4.1.2 includes the fix from microsoft/TypeScript#39537
rimunroe
added a commit
to rimunroe/vitest-commonjs-exports-prototype-issue
that referenced
this pull request
Jan 27, 2023
4.1.2 includes the fix from microsoft/TypeScript#39537
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #37013 as I was unable to push up changes to that PR. Thanks @ExE-Boss!
From @ExE-Boss:
Replaces #37013
Fixes #37016
Fixes #3197