Add DockerFile for ChromeDevTools#39624
Conversation
Note that I was not able to verify it fully works, as it throws an authentication error on typescript/typescript on the Docker Hub. This is part of microsoft#39568 CC @weswigham
| RUN mkdir /typescript | ||
| RUN tar -xzvf /typescript.tgz -C /typescript | ||
| RUN ln -s /typescript/package ./node_modules/typescript | ||
| RUN autoninja -C out/Default front_end No newline at end of file |
There was a problem hiding this comment.
For some reason if this last step is a CMD then it doesn't do anything at all. I am not sure why, but the RUN works as expected.
There was a problem hiding this comment.
A docker file is split into two phases, build and run. All the RUNs build the FS in the Dockerfile. The CMD is what is executed (by default) when you actually execute the built docker image. We use that here - only the CMD output is baseline'd.
There was a problem hiding this comment.
Ah I see, thanks for the explanation.
| WORKDIR / | ||
| RUN mkdir devtools | ||
| WORKDIR devtools | ||
| RUN fetch devtools-frontend |
There was a problem hiding this comment.
The instructions here and below are taken from https://github.com/ChromeDevTools/devtools-frontend/blob/master/docs/workflows.md#standalone-checkout
typescript-bot
added
the
For Uncommitted Bug
|
|
|
I was able to make it run with: I am not sure how best to make the error log as useful for you. The CMD now makes sure that into only shows any failures, if there are any. This should remove all noise from Ninja and produce a stable output. |
|
@typescript-bot user test this |
|
Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 6517bc9. You can monitor the build here. |
|
@weswigham It's been a while since we worked on this PR. Could you let me know what the latest status update for it is? |
4 participants
Note that I was not able to verify it fully works, as it throws an
authentication error on typescript/typescript on the Docker Hub.
This is part of #39568
CC @weswigham