Properly handle tagged primitives in control flow analysis#43538
Merged
ahejlsberg merged 5 commits intomasterfrom Apr 7, 2021
Merged
Properly handle tagged primitives in control flow analysis#43538ahejlsberg merged 5 commits intomasterfrom
ahejlsberg merged 5 commits intomasterfrom
Conversation
typescript-bot
added
Author: Team
For Milestone Bug
DanielRosenwasser
approved these changes
Apr 5, 2021
weswigham
reviewed
Apr 5, 2021
Member
weswigham
left a comment
weswigham
left a comment
There was a problem hiding this comment.
This looks OK, but what about something like T & {__tag: void} & string? Should the T's constraints still be contributing facts? As written they always do, which is... Maybe bad? If T is constrained to tags, I think the original issue recurs.
Member
Author
Yeah, good point. I'll make sure that's handled too. |
weswigham
approved these changes
Apr 6, 2021
Member
weswigham
left a comment
weswigham
left a comment
There was a problem hiding this comment.
A test with union/intersection constraints would be nice, but I think this looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43502.