Improve parsing in await and yield context#44464
Improve parsing in await and yield context#44464Kingwl wants to merge 1 commit intomicrosoft:mainfrom
Conversation
|
I need to run through it in the debugger to understand it myself, but my guess is that isBindingIdentifier accepts |
|
Well, I was sort of right. It's actually an error in the binder, from |
|
Now that I've checked how to clear Yield/AwaitContext, I see that isBindingIdentifier is the same as isIdentifier without the special cases for yield/await. I'd like to see two things:
I think it's probably fine to call isBindingIdentifier instead of isIdentifier; isIdentifier hasn't changed for 5 years, and I assume @rbuckton created a isBindingIdentifier last year instead of passing a boolean to isIdentifier for performance reasons. |
|
Moved to #44680. |
Fixes #44459
It works. But I don't know why 🤷♂️.