Skip to content

Make show param optional#44559

Closed
dhaigh wants to merge 1 commit intomicrosoft:mainfrom
dhaigh:patch-1
Closed

Make show param optional#44559
dhaigh wants to merge 1 commit intomicrosoft:mainfrom
dhaigh:patch-1

Conversation

@dhaigh
Copy link

@dhaigh dhaigh commented Jun 12, 2021

Bug introduced here https://github.com/microsoft/TypeScript/pull/44423/files#diff-796971dc74a3f3cd77ca0a3a776d6fe27ab224cd501d9652dbeffcf45ba0f058R11332

Both in practice and according to the spec the promise parameter is optional.

@typescript-bot
Copy link
Collaborator

It looks like you've sent a pull request to update our 'lib' files. These files aren't meant to be edited by hand, as they consist of last-known good states of the compiler and are generated from 'src'. Unless this is necessary, consider closing the pull request and sending a separate PR to update 'src'.

@typescript-bot typescript-bot added the lib update PR modifies files in the `lib` folder label Jun 12, 2021
@typescript-bot
Copy link
Collaborator

It looks like you've sent a pull request to update some generated declaration files related to the DOM. These files aren't meant to be edited by hand, as they are synchronized with files in the TSJS-lib-generator repository. You can read more here. For house-keeping purposes, this pull request will be closed.

@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jun 12, 2021
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@dhaigh dhaigh deleted the patch-1 branch June 12, 2021 00:04
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug lib update PR modifies files in the `lib` folder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants