Skip to content

Get type arguments lazily for instantiating inferred type parameter constraint#49744

Merged
andrewbranch merged 2 commits intomicrosoft:mainfrom
andrewbranch:bug/48059
Jun 30, 2022
Merged

Get type arguments lazily for instantiating inferred type parameter constraint#49744
andrewbranch merged 2 commits intomicrosoft:mainfrom
andrewbranch:bug/48059

Conversation

@andrewbranch
Copy link
Member

@andrewbranch andrewbranch commented Jun 30, 2022

Fixes #48059

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jun 30, 2022
@andrewbranch
Copy link
Member Author

andrewbranch commented Jun 30, 2022

@typescript-bot perf test this
@typescript-bot user test this inline
@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 30, 2022 •
edited
Loading

Heya @andrewbranch, I've started to run the diff-based user code test suite on this PR at 5b4f1e2. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 30, 2022 •
edited
Loading

Heya @andrewbranch, I've started to run the perf test suite on this PR at 5b4f1e2. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 30, 2022 •
edited
Loading

Heya @andrewbranch, I've started to run the parallelized Definitely Typed test suite on this PR at 5b4f1e2. You can monitor the build here.

andrewbranch
andrewbranch commented Jun 30, 2022
View reviewed changes
src/compiler/checker.ts
// type Foo<T extends string, U extends T> = [T, U];
// type Bar<T> = T extends Foo<infer X, infer X> ? Foo<X, X> : T;
// the instantiated constraint for U is X, so we discard that inference.
const mapper = createTypeMapper(typeParameters, getEffectiveTypeArguments(typeReference, typeParameters));
Copy link
Member Author

@andrewbranch andrewbranch Jun 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the simple repro:

type AMappedType<T> = { [KeyType in keyof T]: number };

type HasM = {
  m: number;
};

// Simplified repro from #48059

interface X1<
  T extends HasM,
  Output = AMappedType<{ s: number; } & { [k in keyof T]: number; }>
> {
  tee: T;
  output: Output;
}

type F1<T> = T extends X1<infer U> ? U : never;

getEffectiveTypeArguments for X1<infer U> was doing all kinds of work to create the default type for Output, which eventually pulls on T who was instantiated with U, creating a circularity. But all this was in service of instantiating HasM which obviously doesn’t need to be instantiated. This simply lazifies getting those type argument types until/unless they’re needed (and also doesn’t bother filling in defaults if they’re never asked for).

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 30, 2022

@andrewbranch
Great news! no new errors were found between main..refs/pull/49744/merge

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 30, 2022

@andrewbranch
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..49744
Metric main 49744 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 359,627k (± 0.02%) 359,673k (± 0.02%) +47k (+ 0.01%) 359,490k 359,898k
Parse Time 2.09s (± 0.50%) 2.09s (± 0.46%) +0.00s (+ 0.14%) 2.07s 2.11s
Bind Time 0.89s (± 0.75%) 0.90s (± 0.55%) +0.00s (+ 0.34%) 0.89s 0.91s
Check Time 5.94s (± 0.54%) 5.94s (± 0.32%) +0.00s (+ 0.07%) 5.91s 5.99s
Emit Time 6.09s (± 0.53%) 6.10s (± 0.64%) +0.00s (+ 0.03%) 6.03s 6.19s
Total Time 15.01s (± 0.31%) 15.02s (± 0.28%) +0.01s (+ 0.06%) 14.95s 15.10s
Compiler-Unions - node (v10.16.3, x64)
Memory used 206,408k (± 0.03%) 206,439k (± 0.03%) +30k (+ 0.01%) 206,295k 206,556k
Parse Time 0.83s (± 1.02%) 0.83s (± 0.88%) -0.00s (- 0.36%) 0.81s 0.84s
Bind Time 0.53s (± 1.59%) 0.53s (± 1.37%) +0.00s (+ 0.57%) 0.51s 0.54s
Check Time 8.08s (± 0.47%) 8.08s (± 0.86%) +0.01s (+ 0.07%) 7.96s 8.28s
Emit Time 2.48s (± 0.84%) 2.48s (± 0.64%) +0.00s (+ 0.16%) 2.46s 2.52s
Total Time 11.92s (± 0.37%) 11.93s (± 0.60%) +0.01s (+ 0.09%) 11.80s 12.14s
Monaco - node (v10.16.3, x64)
Memory used 343,860k (± 0.02%) 343,916k (± 0.02%) +56k (+ 0.02%) 343,822k 344,152k
Parse Time 1.59s (± 0.42%) 1.59s (± 0.48%) +0.01s (+ 0.50%) 1.58s 1.62s
Bind Time 0.76s (± 0.65%) 0.77s (± 0.84%) +0.01s (+ 0.92%) 0.76s 0.79s
Check Time 5.97s (± 0.38%) 5.94s (± 0.53%) -0.02s (- 0.34%) 5.89s 6.01s
Emit Time 3.26s (± 0.79%) 3.26s (± 0.60%) -0.00s (- 0.15%) 3.21s 3.30s
Total Time 11.58s (± 0.26%) 11.57s (± 0.37%) -0.02s (- 0.13%) 11.47s 11.65s
TFS - node (v10.16.3, x64)
Memory used 305,099k (± 0.02%) 305,199k (± 0.02%) +100k (+ 0.03%) 305,058k 305,349k
Parse Time 1.28s (± 0.59%) 1.28s (± 0.55%) -0.01s (- 0.47%) 1.26s 1.29s
Bind Time 0.72s (± 0.83%) 0.72s (± 0.72%) -0.00s (- 0.55%) 0.71s 0.73s
Check Time 5.40s (± 0.49%) 5.42s (± 0.75%) +0.03s (+ 0.48%) 5.36s 5.53s
Emit Time 3.44s (± 1.45%) 3.45s (± 0.92%) +0.01s (+ 0.32%) 3.40s 3.54s
Total Time 10.85s (± 0.45%) 10.88s (± 0.41%) +0.02s (+ 0.21%) 10.77s 11.02s
material-ui - node (v10.16.3, x64)
Memory used 469,094k (± 0.01%) 469,060k (± 0.01%) -34k (- 0.01%) 468,957k 469,239k
Parse Time 1.83s (± 0.73%) 1.83s (± 0.68%) -0.00s (- 0.16%) 1.80s 1.85s
Bind Time 0.69s (± 1.52%) 0.69s (± 1.91%) -0.00s (- 0.14%) 0.66s 0.71s
Check Time 14.43s (± 0.42%) 14.46s (± 0.55%) +0.02s (+ 0.15%) 14.31s 14.66s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.96s (± 0.39%) 16.98s (± 0.50%) +0.02s (+ 0.11%) 16.84s 17.21s
xstate - node (v10.16.3, x64)
Memory used 577,820k (± 0.02%) 577,822k (± 0.01%) +3k (+ 0.00%) 577,609k 577,959k
Parse Time 2.60s (± 0.50%) 2.60s (± 0.37%) -0.00s (- 0.08%) 2.56s 2.61s
Bind Time 1.03s (± 1.09%) 1.03s (± 0.91%) +0.00s (+ 0.39%) 1.01s 1.06s
Check Time 1.54s (± 0.74%) 1.54s (± 0.65%) +0.00s (+ 0.06%) 1.52s 1.56s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.23s (± 0.33%) 5.24s (± 0.32%) +0.00s (+ 0.10%) 5.18s 5.26s
Angular - node (v12.1.0, x64)
Memory used 337,052k (± 0.08%) 337,160k (± 0.01%) +108k (+ 0.03%) 337,073k 337,227k
Parse Time 2.09s (± 0.63%) 2.09s (± 0.66%) -0.00s (- 0.14%) 2.06s 2.12s
Bind Time 0.87s (± 1.00%) 0.87s (± 0.79%) -0.00s (- 0.23%) 0.85s 0.88s
Check Time 5.78s (± 0.44%) 5.78s (± 0.47%) +0.01s (+ 0.10%) 5.72s 5.83s
Emit Time 6.35s (± 0.77%) 6.38s (± 0.81%) +0.03s (+ 0.47%) 6.31s 6.54s
Total Time 15.08s (± 0.50%) 15.12s (± 0.55%) +0.03s (+ 0.21%) 14.99s 15.34s
Compiler-Unions - node (v12.1.0, x64)
Memory used 193,946k (± 0.11%) 194,076k (± 0.07%) +130k (+ 0.07%) 193,536k 194,248k
Parse Time 0.83s (± 0.82%) 0.82s (± 0.92%) -0.00s (- 0.12%) 0.81s 0.85s
Bind Time 0.55s (± 1.06%) 0.55s (± 1.01%) +0.01s (+ 0.91%) 0.54s 0.56s
Check Time 7.61s (± 0.56%) 7.58s (± 0.59%) -0.03s (- 0.38%) 7.47s 7.70s
Emit Time 2.56s (± 1.39%) 2.52s (± 1.05%) -0.03s (- 1.25%) 2.49s 2.61s
Total Time 11.54s (± 0.61%) 11.48s (± 0.47%) -0.06s (- 0.50%) 11.36s 11.60s
Monaco - node (v12.1.0, x64)
Memory used 326,896k (± 0.02%) 326,951k (± 0.02%) +55k (+ 0.02%) 326,825k 327,025k
Parse Time 1.57s (± 0.74%) 1.56s (± 0.47%) -0.01s (- 0.76%) 1.54s 1.57s
Bind Time 0.76s (± 0.77%) 0.76s (± 1.38%) +0.01s (+ 0.79%) 0.75s 0.80s
Check Time 5.77s (± 0.61%) 5.78s (± 0.48%) +0.00s (+ 0.07%) 5.75s 5.85s
Emit Time 3.30s (± 1.00%) 3.30s (± 0.75%) 0.00s ( 0.00%) 3.25s 3.35s
Total Time 11.40s (± 0.62%) 11.40s (± 0.43%) -0.00s (- 0.04%) 11.33s 11.51s
TFS - node (v12.1.0, x64)
Memory used 289,785k (± 0.03%) 289,713k (± 0.02%) -72k (- 0.02%) 289,615k 289,848k
Parse Time 1.30s (± 1.20%) 1.29s (± 0.62%) -0.01s (- 0.69%) 1.27s 1.31s
Bind Time 0.73s (± 0.94%) 0.72s (± 0.47%) -0.00s (- 0.41%) 0.72s 0.73s
Check Time 5.33s (± 0.18%) 5.32s (± 0.32%) -0.02s (- 0.30%) 5.27s 5.35s
Emit Time 3.52s (± 0.74%) 3.54s (± 0.63%) +0.03s (+ 0.71%) 3.49s 3.59s
Total Time 10.87s (± 0.37%) 10.87s (± 0.35%) -0.00s (- 0.05%) 10.76s 10.94s
material-ui - node (v12.1.0, x64)
Memory used 447,942k (± 0.09%) 448,141k (± 0.02%) +199k (+ 0.04%) 447,931k 448,285k
Parse Time 1.83s (± 0.41%) 1.82s (± 0.58%) -0.00s (- 0.16%) 1.80s 1.85s
Bind Time 0.68s (± 0.66%) 0.68s (± 0.44%) +0.00s (+ 0.59%) 0.68s 0.69s
Check Time 13.01s (± 0.69%) 13.07s (± 0.72%) +0.06s (+ 0.45%) 12.89s 13.34s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.51s (± 0.59%) 15.57s (± 0.66%) +0.06s (+ 0.39%) 15.38s 15.87s
xstate - node (v12.1.0, x64)
Memory used 546,484k (± 1.31%) 543,273k (± 0.01%) -3,212k (- 0.59%) 543,101k 543,416k
Parse Time 2.55s (± 0.58%) 2.55s (± 0.40%) -0.00s (- 0.16%) 2.53s 2.58s
Bind Time 1.04s (± 1.17%) 1.03s (± 0.82%) -0.01s (- 0.96%) 1.01s 1.05s
Check Time 1.49s (± 0.52%) 1.49s (± 0.45%) -0.00s (- 0.07%) 1.48s 1.50s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.15s (± 0.33%) 5.14s (± 0.20%) -0.01s (- 0.19%) 5.11s 5.15s
Angular - node (v14.15.1, x64)
Memory used 335,281k (± 0.01%) 335,280k (± 0.01%) -1k (- 0.00%) 335,221k 335,350k
Parse Time 2.05s (± 0.72%) 2.06s (± 0.88%) +0.01s (+ 0.34%) 2.04s 2.12s
Bind Time 0.90s (± 0.75%) 0.90s (± 0.53%) +0.01s (+ 0.67%) 0.89s 0.91s
Check Time 5.74s (± 0.41%) 5.76s (± 0.49%) +0.02s (+ 0.28%) 5.70s 5.80s
Emit Time 6.39s (± 0.85%) 6.41s (± 0.53%) +0.02s (+ 0.27%) 6.35s 6.49s
Total Time 15.08s (± 0.50%) 15.13s (± 0.39%) +0.04s (+ 0.29%) 15.00s 15.28s
Compiler-Unions - node (v14.15.1, x64)
Memory used 192,598k (± 0.08%) 192,705k (± 0.01%) +107k (+ 0.06%) 192,660k 192,751k
Parse Time 0.84s (± 0.58%) 0.85s (± 0.68%) +0.01s (+ 1.07%) 0.84s 0.87s
Bind Time 0.57s (± 1.43%) 0.57s (± 1.04%) +0.00s (+ 0.35%) 0.57s 0.59s
Check Time 7.65s (± 0.89%) 7.67s (± 0.83%) +0.02s (+ 0.29%) 7.53s 7.80s
Emit Time 2.52s (± 0.49%) 2.52s (± 0.83%) +0.00s (+ 0.08%) 2.48s 2.57s
Total Time 11.58s (± 0.70%) 11.62s (± 0.68%) +0.04s (+ 0.30%) 11.45s 11.80s
Monaco - node (v14.15.1, x64)
Memory used 325,644k (± 0.01%) 325,631k (± 0.00%) -14k (- 0.00%) 325,612k 325,656k
Parse Time 1.58s (± 0.52%) 1.57s (± 0.64%) -0.01s (- 0.63%) 1.55s 1.60s
Bind Time 0.79s (± 0.38%) 0.80s (± 1.16%) +0.01s (+ 0.76%) 0.79s 0.83s
Check Time 5.69s (± 0.48%) 5.68s (± 0.26%) -0.01s (- 0.11%) 5.64s 5.71s
Emit Time 3.37s (± 0.53%) 3.35s (± 0.58%) -0.01s (- 0.42%) 3.33s 3.42s
Total Time 11.43s (± 0.29%) 11.40s (± 0.30%) -0.03s (- 0.24%) 11.35s 11.50s
TFS - node (v14.15.1, x64)
Memory used 288,776k (± 0.01%) 288,766k (± 0.01%) -10k (- 0.00%) 288,711k 288,815k
Parse Time 1.33s (± 1.22%) 1.34s (± 1.57%) +0.01s (+ 1.05%) 1.30s 1.39s
Bind Time 0.75s (± 2.10%) 0.76s (± 3.44%) +0.01s (+ 0.67%) 0.74s 0.86s
Check Time 5.32s (± 0.42%) 5.31s (± 0.56%) -0.01s (- 0.24%) 5.27s 5.40s
Emit Time 3.57s (± 2.54%) 3.54s (± 2.06%) -0.03s (- 0.90%) 3.45s 3.70s
Total Time 10.97s (± 0.83%) 10.95s (± 0.68%) -0.03s (- 0.25%) 10.81s 11.14s
material-ui - node (v14.15.1, x64)
Memory used 446,339k (± 0.01%) 446,223k (± 0.06%) -116k (- 0.03%) 445,205k 446,395k
Parse Time 1.87s (± 0.60%) 1.88s (± 0.66%) +0.01s (+ 0.32%) 1.85s 1.90s
Bind Time 0.72s (± 1.15%) 0.73s (± 1.58%) +0.01s (+ 1.24%) 0.72s 0.77s
Check Time 13.12s (± 0.56%) 13.20s (± 1.00%) +0.08s (+ 0.62%) 12.91s 13.59s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.72s (± 0.51%) 15.82s (± 0.91%) +0.10s (+ 0.65%) 15.50s 16.23s
xstate - node (v14.15.1, x64)
Memory used 541,035k (± 0.00%) 541,074k (± 0.00%) +39k (+ 0.01%) 541,041k 541,118k
Parse Time 2.60s (± 0.61%) 2.60s (± 0.34%) +0.01s (+ 0.23%) 2.58s 2.62s
Bind Time 1.14s (± 1.09%) 1.16s (± 0.81%) +0.02s (+ 1.76%) 1.13s 1.18s
Check Time 1.54s (± 0.64%) 1.54s (± 0.73%) +0.00s (+ 0.20%) 1.52s 1.56s
Emit Time 0.07s (± 4.95%) 0.07s (± 4.66%) -0.00s (- 2.67%) 0.07s 0.08s
Total Time 5.35s (± 0.40%) 5.38s (± 0.23%) +0.03s (+ 0.60%) 5.35s 5.40s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 49744 10
Baseline main 10

TSServer

Comparison Report - main..49744
Metric main 49744 Delta Best Worst
xstateTSServer - node (v10.16.3, x64)
Initial load time 2,163.90ms (± 0.49%) 2,159.00ms (± 0.34%) -4.90ms (- 0.23%) 2,146.00ms 2,181.00ms
Geterr time 751.00ms (± 0.42%) 752.00ms (± 0.53%) +1.00ms (+ 0.13%) 746.00ms 760.00ms
References time 98.70ms (± 1.12%) 94.90ms (± 1.42%) 🟩-3.80ms (- 3.85%) 93.00ms 99.00ms
Navto time 252.40ms (± 1.30%) 250.30ms (± 0.84%) -2.10ms (- 0.83%) 246.00ms 254.00ms
Navto count 256.00 (± 0.00%) 256.00 (± 0.00%) 0.00 ( 0.00%) 256.00 256.00
Completions time 239.90ms (± 1.85%) 245.00ms (± 1.83%) +5.10ms (+ 2.13%) 237.00ms 253.00ms
Completions count 3,205.00 (± 0.00%) 3,205.00 (± 0.00%) 0.00 ( 0.00%) 3,205.00 3,205.00
xstateTSServer - node (v12.1.0, x64)
Initial load time 2,108.80ms (± 0.45%) 2,095.40ms (± 0.44%) -13.40ms (- 0.64%) 2,080.00ms 2,122.00ms
Geterr time 748.70ms (± 0.49%) 743.00ms (± 0.35%) -5.70ms (- 0.76%) 737.00ms 748.00ms
References time 67.60ms (± 0.54%) 68.00ms (± 1.09%) +0.40ms (+ 0.59%) 66.00ms 69.00ms
Navto time 236.10ms (± 0.89%) 239.50ms (± 1.61%) +3.40ms (+ 1.44%) 230.00ms 249.00ms
Navto count 256.00 (± 0.00%) 256.00 (± 0.00%) 0.00 ( 0.00%) 256.00 256.00
Completions time 244.40ms (± 1.47%) 240.30ms (± 0.77%) -4.10ms (- 1.68%) 236.00ms 243.00ms
Completions count 3,205.00 (± 0.00%) 3,205.00 (± 0.00%) 0.00 ( 0.00%) 3,205.00 3,205.00
xstateTSServer - node (v14.15.1, x64)
Initial load time 2,226.50ms (± 0.42%) 2,233.20ms (± 0.34%) +6.70ms (+ 0.30%) 2,217.00ms 2,246.00ms
Geterr time 762.30ms (± 0.44%) 763.30ms (± 0.53%) +1.00ms (+ 0.13%) 756.00ms 773.00ms
References time 68.10ms (± 1.24%) 65.70ms (± 1.75%) 🟩-2.40ms (- 3.52%) 64.00ms 69.00ms
Navto time 251.30ms (± 1.59%) 249.30ms (± 0.68%) -2.00ms (- 0.80%) 247.00ms 253.00ms
Navto count 256.00 (± 0.00%) 256.00 (± 0.00%) 0.00 ( 0.00%) 256.00 256.00
Completions time 246.60ms (± 3.71%) 243.50ms (± 0.76%) -3.10ms (- 1.26%) 240.00ms 248.00ms
Completions count 3,205.00 (± 0.00%) 3,205.00 (± 0.00%) 0.00 ( 0.00%) 3,205.00 3,205.00
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • xstateTSServer - node (v10.16.3, x64)
  • xstateTSServer - node (v12.1.0, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 49744 10
Baseline main 10

Developer Information:

Download Benchmark

@andrewbranch andrewbranch requested a review from weswigham June 30, 2022 19:58
weswigham
weswigham reviewed Jun 30, 2022
View reviewed changes
@andrewbranch andrewbranch requested a review from weswigham June 30, 2022 23:03
@andrewbranch andrewbranch merged commit f8aa570 into microsoft:main Jun 30, 2022
@andrewbranch andrewbranch deleted the bug/48059 branch June 30, 2022 23:30
@ahejlsberg ahejlsberg mentioned this pull request Sep 15, 2022
Closed
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswigham weswigham weswigham approved these changes

Assignees

@andrewbranch andrewbranch

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exclude causes infer to break

3 participants

@andrewbranch @typescript-bot @weswigham