Skip to content

Exclude 'prototype' from 'keyof typeof SomeClassDecl'#55471

Closed
RyanCavanaugh wants to merge 2 commits intomicrosoft:mainfrom
RyanCavanaugh:removePrototypeFromKeyof
Closed

Exclude 'prototype' from 'keyof typeof SomeClassDecl'#55471
RyanCavanaugh wants to merge 2 commits intomicrosoft:mainfrom
RyanCavanaugh:removePrototypeFromKeyof

Conversation

@RyanCavanaugh
Copy link
Member

@RyanCavanaugh RyanCavanaugh commented Aug 22, 2023

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Aug 22, 2023
@RyanCavanaugh
Merge branch 'main' into removePrototypeFromKeyof
ffa3cc4 
# Conflicts:
#	src/compiler/checker.ts
@RyanCavanaugh
Copy link
Member Author

RyanCavanaugh commented Aug 22, 2023

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 22, 2023 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite (tsserver) on this PR at ffa3cc4. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 22, 2023 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the diff-based user code test suite on this PR at ffa3cc4. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 22, 2023 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite on this PR at ffa3cc4. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 22, 2023 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the regular perf test suite on this PR at ffa3cc4. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 22, 2023 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at ffa3cc4. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 22, 2023 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the diff-based user code test suite (tsserver) on this PR at ffa3cc4. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 22, 2023 •
edited
Loading

Heya @RyanCavanaugh, I've started to run the tarball bundle task on this PR at ffa3cc4. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 22, 2023 •
edited
Loading

Hey @RyanCavanaugh, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/156814/artifacts?artifactName=tgz&fileId=CB70C49558564D4ACCCAEBE0879203AB5263C4295B9D0C8058F26A33E31E38E202&fileName=/typescript-5.3.0-insiders.20230822.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.3.0-pr-55471-8".;

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 22, 2023

@RyanCavanaugh Here are the results of running the user test suite comparing main and refs/pull/55471/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 22, 2023

@RyanCavanaugh Here are the results of running the user test suite comparing main and refs/pull/55471/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Unknown failure"
  • 2 instances of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

  • [NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-55471/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-55471/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55471/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-55471/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-55471/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55471/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-55471/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-55471/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55471/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-55471/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-55471/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55471/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-55471/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-55471/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-55471/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
  • [MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(62,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
    • /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 22, 2023

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 300,323k (± 0.00%) 300,338k (± 0.01%) ~ 300,311k 300,378k p=0.229 n=6
Parse Time 3.03s (± 0.17%) 3.02s (± 0.18%) ~ 3.02s 3.03s p=0.640 n=6
Bind Time 0.93s (± 0.00%) 0.93s (± 0.00%) ~ 0.93s 0.93s p=1.000 n=6
Check Time 9.46s (± 0.33%) 9.48s (± 0.39%) ~ 9.43s 9.54s p=0.571 n=6
Emit Time 7.63s (± 0.40%) 7.64s (± 0.38%) ~ 7.61s 7.68s p=0.808 n=6
Total Time 21.05s (± 0.23%) 21.07s (± 0.19%) ~ 21.02s 21.13s p=0.627 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 193,917k (± 0.02%) 193,879k (± 0.02%) ~ 193,834k 193,912k p=0.065 n=6
Parse Time 1.57s (± 1.05%) 1.55s (± 0.79%) ~ 1.55s 1.58s p=0.282 n=6
Bind Time 0.79s (± 0.52%) 0.79s (± 0.00%) ~ 0.79s 0.79s p=0.405 n=6
Check Time 9.95s (± 0.32%) 9.92s (± 0.23%) ~ 9.90s 9.96s p=0.072 n=6
Emit Time 2.74s (± 0.27%) 2.75s (± 0.38%) ~ 2.73s 2.76s p=0.155 n=6
Total Time 15.04s (± 0.31%) 15.01s (± 0.18%) ~ 14.98s 15.05s p=0.126 n=6
Monaco - node (v16.17.1, x64)
Memory used 347,120k (± 0.01%) 347,133k (± 0.01%) ~ 347,086k 347,151k p=0.378 n=6
Parse Time 2.69s (± 0.38%) 2.69s (± 0.28%) ~ 2.68s 2.70s p=0.931 n=6
Bind Time 0.99s (± 0.00%) 0.99s (± 0.41%) ~ 0.99s 1.00s p=0.405 n=6
Check Time 7.93s (± 0.27%) 7.90s (± 0.30%) ~ 7.87s 7.93s p=0.075 n=6
Emit Time 4.27s (± 0.19%) 4.26s (± 0.30%) ~ 4.25s 4.28s p=0.281 n=6
Total Time 15.87s (± 0.20%) 15.84s (± 0.12%) ~ 15.80s 15.85s p=0.167 n=6
TFS - node (v16.17.1, x64)
Memory used 301,136k (± 0.00%) 301,149k (± 0.00%) ~ 301,137k 301,162k p=0.149 n=6
Parse Time 2.18s (± 0.45%) 2.17s (± 0.45%) ~ 2.16s 2.18s p=0.242 n=6
Bind Time 1.11s (± 0.37%) 1.11s (± 0.37%) ~ 1.10s 1.11s p=0.218 n=6
Check Time 7.25s (± 0.28%) 7.23s (± 0.42%) ~ 7.21s 7.29s p=0.075 n=6
Emit Time 3.98s (± 0.43%) 3.97s (± 0.58%) ~ 3.95s 4.00s p=0.453 n=6
Total Time 14.52s (± 0.19%) 14.49s (± 0.27%) ~ 14.43s 14.54s p=0.142 n=6
material-ui - node (v16.17.1, x64)
Memory used 479,467k (± 0.00%) 479,485k (± 0.00%) ~ 479,475k 479,505k p=0.149 n=6
Parse Time 3.15s (± 0.13%) 3.15s (± 0.43%) ~ 3.14s 3.18s p=0.673 n=6
Bind Time 0.91s (± 0.00%) 0.91s (± 0.00%) ~ 0.91s 0.91s p=1.000 n=6
Check Time 17.93s (± 0.32%) 17.90s (± 0.30%) ~ 17.85s 17.98s p=0.260 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.98s (± 0.27%) 21.96s (± 0.22%) ~ 21.91s 22.04s p=0.419 n=6
xstate - node (v16.17.1, x64)
Memory used 542,866k (± 0.01%) 542,828k (± 0.01%) ~ 542,776k 542,938k p=0.230 n=6
Parse Time 3.70s (± 0.17%) 3.70s (± 0.11%) ~ 3.69s 3.70s p=0.673 n=6
Bind Time 1.35s (± 3.51%) 1.38s (± 4.15%) ~ 1.34s 1.46s p=0.143 n=6
Check Time 3.34s (± 1.74%) 3.28s (± 2.37%) ~ 3.18s 3.34s p=0.062 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 4.99%) ~ 0.08s 0.09s p=0.405 n=6
Total Time 8.47s (± 0.31%) 8.44s (± 0.29%) -0.04s (- 0.45%) 8.40s 8.47s p=0.045 n=6
System info unknown
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

tsserver

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,488ms (± 0.16%) 2,494ms (± 0.17%) ~ 2,488ms 2,499ms p=0.054 n=6
Req 2 - geterr 5,963ms (± 0.39%) 5,962ms (± 0.21%) ~ 5,946ms 5,978ms p=1.000 n=6
Req 3 - references 345ms (± 0.97%) 342ms (± 0.35%) ~ 341ms 344ms p=0.105 n=6
Req 4 - navto 279ms (± 1.05%) 279ms (± 1.13%) ~ 276ms 283ms p=0.738 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 86ms (± 9.32%) 80ms (± 3.65%) ~ 76ms 83ms p=0.257 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,625ms (± 0.72%) 2,631ms (± 0.99%) ~ 2,605ms 2,662ms p=0.572 n=6
Req 2 - geterr 4,763ms (± 0.24%) 4,771ms (± 0.19%) ~ 4,761ms 4,782ms p=0.199 n=6
Req 3 - references 350ms (± 0.26%) 350ms (± 0.26%) ~ 349ms 351ms p=1.000 n=6
Req 4 - navto 269ms (± 0.36%) 270ms (± 0.28%) ~ 269ms 271ms p=0.300 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 79ms (± 0.80%) 79ms (± 0.52%) ~ 79ms 80ms p=0.673 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,718ms (± 0.23%) 2,719ms (± 0.19%) ~ 2,711ms 2,725ms p=0.747 n=6
Req 2 - geterr 1,923ms (± 2.29%) 1,943ms (± 1.81%) ~ 1,874ms 1,969ms p=0.470 n=6
Req 3 - references 133ms (± 4.73%) 138ms (± 2.80%) ~ 134ms 142ms p=0.075 n=6
Req 4 - navto 354ms (± 0.39%) 353ms (± 0.42%) ~ 351ms 355ms p=0.458 n=6
Req 5 - completionInfo count 2,071 (± 0.00%) 2,071 (± 0.00%) ~ 2,071 2,071 p=1.000 n=6
Req 5 - completionInfo 319ms (± 2.16%) 323ms (± 2.08%) ~ 315ms 329ms p=0.629 n=6
System info unknown
Hosts
  • node (v16.17.1, x64)
Scenarios
  • CompilerTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v16.17.1, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Startup

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 155.54ms (± 0.16%) 155.50ms (± 0.18%) -0.04ms (- 0.02%) 154.38ms 161.82ms p=0.025 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 230.22ms (± 0.14%) 230.91ms (± 0.15%) +0.69ms (+ 0.30%) 229.15ms 236.57ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 234.70ms (± 0.13%) 236.09ms (± 0.15%) +1.39ms (+ 0.59%) 234.49ms 243.06ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 235.87ms (± 0.12%) 235.76ms (± 0.12%) -0.11ms (- 0.05%) 234.50ms 239.26ms p=0.000 n=600
System info unknown
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 22, 2023

@RyanCavanaugh Here are the results of running the top-repos suite comparing main and refs/pull/55471/merge:

Everything looks good!

1 similar comment
@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 22, 2023

@RyanCavanaugh Here are the results of running the top-repos suite comparing main and refs/pull/55471/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 22, 2023

Hey @RyanCavanaugh, the results of running the DT tests are ready.
There were interesting changes:

Branch only errors:

Package: forest-express-mongoose
Error:

Error: Errors in typescript@local for external dependencies:
node_modules/mongoose/types/inferschematype.d.ts(226,97): error TS2536: Type '"prototype"' cannot be used to index type 'PathValueType'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: mongoose-lean-virtuals
Error:

Error: Errors in typescript@local for external dependencies:
node_modules/mongoose/types/inferschematype.d.ts(226,97): error TS2536: Type '"prototype"' cannot be used to index type 'PathValueType'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: mongoose-deep-populate
Error:

Error: Errors in typescript@local for external dependencies:
node_modules/mongoose/types/inferschematype.d.ts(226,97): error TS2536: Type '"prototype"' cannot be used to index type 'PathValueType'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: multer-gridfs-storage
Error:

Error: Errors in typescript@local for external dependencies:
node_modules/mongoose/types/inferschematype.d.ts(226,97): error TS2536: Type '"prototype"' cannot be used to index type 'PathValueType'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: mongoose-aggregate-paginate-v2
Error:

Error: Errors in typescript@local for external dependencies:
node_modules/mongoose/types/inferschematype.d.ts(226,99): error TS2536: Type '"prototype"' cannot be used to index type 'PathValueType'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: mongoose-delete
Error:

Error: Errors in typescript@local for external dependencies:
node_modules/mongoose/types/inferschematype.d.ts(226,99): error TS2536: Type '"prototype"' cannot be used to index type 'PathValueType'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: mongoose-mock
Error:

Error: Errors in typescript@local for external dependencies:
node_modules/mongoose/types/inferschematype.d.ts(226,97): error TS2536: Type '"prototype"' cannot be used to index type 'PathValueType'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: mongoose-sequence
Error:

Error: Errors in typescript@local for external dependencies:
node_modules/mongoose/types/inferschematype.d.ts(226,97): error TS2536: Type '"prototype"' cannot be used to index type 'PathValueType'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: multer-gridfs-storage/v3
Error:

Error: Errors in typescript@local for external dependencies:
node_modules/mongoose/types/inferschematype.d.ts(226,97): error TS2536: Type '"prototype"' cannot be used to index type 'PathValueType'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: mongoose-auto-increment
Error:

Error: Errors in typescript@local for external dependencies:
node_modules/mongoose/types/inferschematype.d.ts(226,97): error TS2536: Type '"prototype"' cannot be used to index type 'PathValueType'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: mongoose-geojson-schema
Error:

Error: Errors in typescript@local for external dependencies:
node_modules/mongoose/types/inferschematype.d.ts(226,97): error TS2536: Type '"prototype"' cannot be used to index type 'PathValueType'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: mongoose-simple-random
Error:

Error: Errors in typescript@local for external dependencies:
node_modules/mongoose/types/inferschematype.d.ts(226,97): error TS2536: Type '"prototype"' cannot be used to index type 'PathValueType'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: mongoose-paginate
Error:

Error: Errors in typescript@local for external dependencies:
node_modules/mongoose/types/inferschematype.d.ts(226,97): error TS2536: Type '"prototype"' cannot be used to index type 'PathValueType'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: koa2-ratelimit
Error:

Error: Errors in typescript@local for external dependencies:
node_modules/mongoose/types/inferschematype.d.ts(226,97): error TS2536: Type '"prototype"' cannot be used to index type 'PathValueType'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: mongoose-autopopulate
Error:

Error: Errors in typescript@local for external dependencies:
node_modules/mongoose/types/inferschematype.d.ts(226,97): error TS2536: Type '"prototype"' cannot be used to index type 'PathValueType'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: mongoose-id-validator
Error:

Error: Errors in typescript@local for external dependencies:
node_modules/mongoose/types/inferschematype.d.ts(226,97): error TS2536: Type '"prototype"' cannot be used to index type 'PathValueType'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: mongoose-unique-validator
Error:

Error: Errors in typescript@local for external dependencies:
node_modules/mongoose/types/inferschematype.d.ts(226,97): error TS2536: Type '"prototype"' cannot be used to index type 'PathValueType'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: passport-local-mongoose
Error:

Error: Errors in typescript@local for external dependencies:
node_modules/mongoose/types/inferschematype.d.ts(226,97): error TS2536: Type '"prototype"' cannot be used to index type 'PathValueType'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

You can check the log here.

@DanielRosenwasser DanielRosenwasser mentioned this pull request Aug 25, 2023
Closed
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@RyanCavanaugh RyanCavanaugh

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RyanCavanaugh @typescript-bot