Skip to content

Update lib.dom.d.ts: MutationObserverInit.attributeFilter can accept an iterator#55989

Open
trusktr wants to merge 1 commit intomicrosoft:mainfrom
trusktr:patch-2
Open

Update lib.dom.d.ts: MutationObserverInit.attributeFilter can accept an iterator#55989
trusktr wants to merge 1 commit intomicrosoft:mainfrom
trusktr:patch-2

Conversation

@trusktr
Copy link
Contributor

@trusktr trusktr commented Oct 5, 2023

Re-opening of #50031. Please see description there.

Please point me to guidance on how to make this change, and I'll update the PR.

Closes #55990

`MutationObserverInit.attributeFilter` can accept an iterator
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 5, 2023
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@fatcerberus
Copy link

The bot pointed you to the relevant documentation in #50031 but basically you have to make changes to the DOM libs at https://github.com/Microsoft/TSJS-lib-generator, because the ones in the TS repo are autogenerated from there.

@jakebailey
Copy link
Member

The bot pointed you to the relevant documentation in #50031 but basically you have to make changes to the DOM libs at Microsoft/TSJS-lib-generator, because the ones in the TS repo are autogenerated from there.

That time, they had edited lib, which used to hold a checked-in compiler for self compilation and no longer exists (hence why this hasn't been auto-closed yet). So this PR is "fine" contribution wise. Of course, the PR has syntax error and I'm not convinced it's correct, either.

@fatcerberus
Copy link

Hmm, so is TSJS-lib-generator obsolete now?

@jakebailey
Copy link
Member

No, there are bits that are generated, and there are bits that aren't. E.g. https://github.com/microsoft/TypeScript/pull/54725/files pulls from the generator but only touches generated files.

@typescript-bot typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 2, 2023
@RyanCavanaugh RyanCavanaugh added this to the Post-7.0 lib candidates milestone Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

Status: Waiting on reviewers

Development

Successfully merging this pull request may close these issues.

Update lib.dom.d.ts: MutationObserverInit.attributeFilter can accept an iterator

7 participants