Exposed TypeChecker.resolveName API to public along with SymbolFlags.All#56932
Merged
jakebailey merged 2 commits intomicrosoft:mainfrom Jan 19, 2024
timocov:expose-resolveName-api
Merged
Exposed TypeChecker.resolveName API to public along with SymbolFlags.All#56932jakebailey merged 2 commits intomicrosoft:mainfrom timocov:expose-resolveName-api
TypeChecker.resolveName API to public along with SymbolFlags.All#56932jakebailey merged 2 commits intomicrosoft:mainfrom
timocov:expose-resolveName-api
Conversation
…gs.All` Related to #46793
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
andrewbranch
reviewed
Jan 3, 2024
Member
|
@timocov is there a reason this is a draft? Were you planning to add anything else? |
Contributor
Author
|
Not really, I wasn't sure if this is the change you'd want to see in the compiler (asked in the linked issue but haven't got any response yet). If that's alright I can mark it as ready for review. |
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Contributor
Author
|
@andrewbranch @rbuckton is there anything I can do to get this merged? |
Member
|
FWIW we did decide to expose this in today's design meeting, so it's just the |
jakebailey
reviewed
Jan 19, 2024
jakebailey
reviewed
Jan 19, 2024
Member
|
I just merged the suggestion to get this along; want to get this in before we cut for the beta. |
jakebailey
approved these changes
Jan 19, 2024
Member
|
@typescript-bot test top200 @typescript-bot perf test this @typescript-bot user test tsserver |
Collaborator
|
Heya @jakebailey, I've started to run the diff-based user code test suite (tsserver) on this PR at fd6f476. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at fd6f476. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @jakebailey, I've started to run the regular perf test suite on this PR at fd6f476. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @jakebailey, I've started to run the diff-based top-repos suite (tsserver) on this PR at fd6f476. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at fd6f476. You can monitor the build here. Update: The results are in! |
Collaborator
|
Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at fd6f476. You can monitor the build here. Update: The results are in! |
andrewbranch
approved these changes
Jan 19, 2024
Collaborator
|
@jakebailey Here are the results of running the user test suite comparing Everything looks good! |
Collaborator
|
@jakebailey Here are the results of running the user test suite comparing There were infrastructure failures potentially unrelated to your change:
Otherwise... Something interesting changed - please have a look. Details
|
Collaborator
|
Hey @jakebailey, the results of running the DT tests are ready. |
Collaborator
|
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
startupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Collaborator
|
@jakebailey Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. Details
|
Collaborator
|
@jakebailey Here are the results of running the top-repos suite comparing Something interesting changed - please have a look. DetailsServer exited prematurely with code unknown and signal SIGABRTAffected reposcalcom/cal.comRaw error text:RepoResults7/calcom.cal.com.rawError.txt in the artifact folder
Last few requests{"seq":754,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/apps/swagger/pages/index.tsx","line":4,"offset":52}}
{"seq":755,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/apps/swagger/pages/index.tsx","line":4,"offset":52}}
{"seq":756,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":["@PROJECT_ROOT@/apps/api/test/lib/middleware/httpMethods.test.ts"],"openFiles":[]}}
{"seq":757,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/apps/web/abTest/middlewareFactory.ts","projectRootPath":"@PROJECT_ROOT@"}]}}
Repro steps
|
Member
|
None of the above is new; merging. Thanks for the PR, @timocov! |
timocov
added a commit
to timocov/dts-bundle-generator
that referenced
this pull request
Jan 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #46793 (doesn't actually fixes it, but partially addresses - see #46793 (comment))