Skip to content

fix(rust): pin rust to a version available on fedora repo #16449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christopherco merged 1 commit into from
Apr 4, 2026
+3 −3
Merged

fix(rust): pin rust to a version available on fedora repo #16449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions base/comps/rust/rust.comp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[components.rust]
# Fedora repo does not have 1.93 which the spec gets pinned to. Snapshot from a
# later version to pickup a later version - 1.94, which is available.
spec = { type = "upstream", upstream-distro = { name = "fedora", version = "43", snapshot = "2026-03-10T00:00:00-08:00" } }
# Fedora repo does not host 1.93, which the spec gets pinned to. Fetch
# spec from a more recent commit to pickup version - 1.94.1.
Comment on lines +2 to +3
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When pinning a component via spec.upstream-commit, this repo’s guidance expects a reference link (e.g., Fedora dist-git commit URL) and an explicit TODO/exit condition for removing the pin once the default snapshot advances. Please add a comment like other pinned components (e.g., golang) with the Fedora commit URL for b431103e… and when/how to drop the override.

Suggested change
# Fedora repo does not host 1.93, which the spec gets pinned to. Fetch
# spec from a more recent commit to pickup version - 1.94.1.
# Fedora 43's default imported snapshot is older than the rust spec we need here.
# Pin to the newer Fedora dist-git commit that carries rust 1.94.1:
# https://src.fedoraproject.org/rpms/rust/c/b431103e3e71d30dda680c95d2f5d4fe50003436
# TODO: Drop `upstream-commit` once the default Fedora 43 snapshot imported by this
# repo advances to include this commit (or a newer rust spec with 1.94.1+), then
# fall back to the normal upstream Fedora source selection.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar/wording: “pickup” should be “pick up” (e.g., “pick up version 1.94.1”).

Suggested change
# spec from a more recent commit to pickup version - 1.94.1.
# spec from a more recent commit to pick up version - 1.94.1.

Copilot uses AI. Check for mistakes.
Comment on lines +2 to +3
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description says we were previously pinned to Rust 1.94.0 and are moving to 1.94.1 due to Fedora repo availability, but the in-file comment focuses on 1.93 being unavailable. Please align the comment with the actual motivation (or update the PR description) so future readers understand why this upstream commit pin exists.

Copilot uses AI. Check for mistakes.
spec = { type = "upstream", upstream-distro = { name = "fedora", version = "43"}, upstream-commit = "b431103e3e71d30dda680c95d2f5d4fe50003436" }
Loading