Skip to content

workaround: disable %check for failing perl packages#16460

Merged
christopherco merged 1 commit intotomls/base/mainfrom
bphilip/perlnotest
Apr 4, 2026
Merged

workaround: disable %check for failing perl packages#16460
christopherco merged 1 commit intotomls/base/mainfrom
bphilip/perlnotest

Conversation

@binujp
Copy link
Copy Markdown
Contributor

@binujp binujp commented Apr 4, 2026

This could be a package incompatibly issue which can be sorted out later during stage2 build.

Koji build succeeded for all these packages after disabling %check.

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Change Log
  • Change
  • Change
  • Change
Does this affect the toolchain?

YES/NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Pipeline build id: xxxx

This could be a package incompatility issue which can be sorted out later during stage2 build.
Copilot AI review requested due to automatic review settings April 4, 2026 04:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the component configuration to temporarily disable %check for several failing Perl-related packages during initial distro bringup/stage2 builds, aligning with the existing “check-skip-initial-failures” mechanism.

Changes:

  • Added multiple perl-* components to the component-groups.check-skip-initial-failures.components list to skip %check by default for those packages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +172 to +177
"perl-SOAP-Lite",
"perl-XML-Catalog",
"perl-XML-DOM",
"perl-XML-Simple",
"perl-XML-Twig",
"perl-XML-XPath",
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For readability/maintainability, these newly added perl-* components would be easier to find if they were placed alongside the existing perl/perl-POE entries (or otherwise kept in a consistent ordering within the list), rather than appended after "virt-v2v".

Suggested change
"perl-SOAP-Lite",
"perl-XML-Catalog",
"perl-XML-DOM",
"perl-XML-Simple",
"perl-XML-Twig",
"perl-XML-XPath",

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator

@christopherco christopherco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@christopherco christopherco merged commit f2008c6 into tomls/base/main Apr 4, 2026
9 checks passed
@christopherco christopherco deleted the bphilip/perlnotest branch April 4, 2026 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants