workaround rust-nix* test failures due to 4-part kernel version issue#16461
Draft
christopherco wants to merge 4 commits intotomls/base/mainfrom
Draft
workaround rust-nix* test failures due to 4-part kernel version issue#16461christopherco wants to merge 4 commits intotomls/base/mainfrom
christopherco wants to merge 4 commits intotomls/base/mainfrom
Conversation
Azure Linux 3.0 kernels, used on our current Koji builders, have 4-part version strings (e.g. 6.6.121.1-1.azl3) which the semver crate's Version::parse() rejects. Three tests (gro, gso, test_txtime) panic on unwrap of the parse error. Apply the same fix-4part-kernel-version.patch already used by rust-nix: truncate to 3 numeric components before parsing so the extra part becomes a pre-release suffix (which is cleared immediately after).
Azure Linux 3.0 kernels, used on our current Koji builders, have 4-part version strings (e.g. 6.6.121.1-1.azl3) which the semver crate's Version::parse() rejects. Three tests (gro, gso, test_txtime) panic on unwrap of the parse error. Apply the same fix-4part-kernel-version.patch already used by rust-nix: truncate to 3 numeric components before parsing so the extra part becomes a pre-release suffix (which is cleared immediately after).
Azure Linux 3.0 kernels, used on our current Koji builders, have 4-part version strings (e.g. 6.6.121.1-1.azl3) which the semver crate's Version::parse() rejects. Three tests (gro, gso, test_txtime) panic on unwrap of the parse error. Apply the same fix-4part-kernel-version.patch already used by rust-nix: truncate to 3 numeric components before parsing so the extra part becomes a pre-release suffix (which is cleared immediately after).
Azure Linux 3.0 kernels, used on our current Koji builders, have 4-part version strings (e.g. 6.6.121.1-1.azl3) which the semver crate's Version::parse() rejects. Two tests (gro, gso) panic on unwrap of the parse error. Apply the same fix-4part-kernel-version.patch already used by rust-nix: truncate to 3 numeric components before parsing so the extra part becomes a pre-release suffix (which is cleared immediately after).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure Linux 3.0 kernels, used on our current Koji builders, have 4-part
version strings (e.g. 6.6.121.1-1.azl3) which the semver crate's
Version::parse() rejects. Two tests (gro, gso) panic on unwrap of the
parse error.
Apply the same fix-4part-kernel-version.patch already used by rust-nix:
truncate to 3 numeric components before parsing so the extra part
becomes a pre-release suffix (which is cleared immediately after).
Apply to rust-nix0.23, rust-nix0.28, rust-nix0.29, rust-nix0.30.
This workaround can be undone when the Koji builders move to a
kernel with 3-part version strings, although the current logic will still
continue to function as intended with a standard 3-part kernel version
string.