[api-extractor] Adds support for surfacing whether a class member is protected#3387
Merged
octogonz merged 2 commits intomicrosoft:mainfrom Jun 7, 2022
Merged
[api-extractor] Adds support for surfacing whether a class member is protected#3387octogonz merged 2 commits intomicrosoft:mainfrom
octogonz merged 2 commits intomicrosoft:mainfrom
Conversation
zelliott
requested review from
D4N14L,
apostolisms,
iclanton,
octogonz and
sachinjoseph
as code owners
iclanton
approved these changes
May 4, 2022
common/changes/@microsoft/api-extractor-model/protected-mixin_2022-05-03-14-54.json
Outdated
Show resolved
Hide resolved
common/changes/@microsoft/api-extractor/protected-mixin_2022-05-03-14-54.json
Outdated
Show resolved
Hide resolved
Member
|
This looks good to me. @octogonz - can you take a look as well so we can get this in? |
octogonz
reviewed
May 5, 2022
octogonz
reviewed
May 5, 2022
calbearox
approved these changes
May 8, 2022
calbearox
left a comment
calbearox
left a comment
There was a problem hiding this comment.
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
Contributor
Author
|
@octogonz This should be good to merge. The api-documenter changes were pulled out into zelliott#2. |
Collaborator
|
Awesome, thanks @zelliott for implementing this! |
Qjuh
pushed a commit
to discordjs/rushstack
that referenced
this pull request
Nov 7, 2023
[api-extractor] Adds support for surfacing whether a class member is protected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3386.
Details
ApiProtectedMixinmixin similar to the existingApiStaticMixinmixin. Applies this mixin to the class constructor, property, and method API items.protectedmodifier.How it was tested
Added some additional test cases to the build tests, ran
rush rebuild, manually verified that the.api.jsonfiles looked correct.