fix: avoid fetching the user's addressbooks per component instance#4794
fix: avoid fetching the user's addressbooks per component instance#4794
Conversation
| } | ||
|
|
||
| this.promise = (async () => { | ||
| await client.connect({ enableCardDAV: true }) |
There was a problem hiding this comment.
This isn’t exactly what Richard suggested, but I dropped that approach because I couldn’t get it to work. In hindsight, I think the idea itself was fine, but I realized too late that the Vuex store was already shared between components, while the Pinia instances were not. Since I created a new Pinia store for it, that was probably the issue I was running into.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
src/store/addressbooks.js
Outdated
| return context.getters.getAddressbooks | ||
| } | ||
|
|
||
| context.state.addressbooksFetched = true |
There was a problem hiding this comment.
The shared pinia store + this should do the trick, right? The promise hack seems superfluous
There was a problem hiding this comment.
I'm afraid not. The shared pinia store is the requirement to make the promise hack work 🙈
There was a problem hiding this comment.
I'm going to revert this line as it's actually unrelated.
There was a problem hiding this comment.
Huh. I was pretty sure that moving the flag toggle up could solve the issue elegantly. The first call of the action actually fetches addressbooks the other ones return early. This is fine if the result of the action is not used but address books populate reactively once loaded.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
bug/noid/contact-details-singleton
branch
from
99ee72a to
7bbe969
Compare
2 participants
How to test:
Before: You should see one request for each recipient to
PROPFIND /remote.php/dav/principals/users/alice/andPROPFIND /remote.php/dav/addressbooks/users/alice/After: You should see only one request to
PROPFIND /remote.php/dav/principals/users/alice/andPROPFIND /remote.php/dav/addressbooks/users/alice/