Skip to content

Add FORWARDED_FOR_HEADERS to the reverse-proxy config#2272

Merged
J0WI merged 2 commits intonextcloud:masterfrom
dgiebert:master
Oct 8, 2024
Merged

Add FORWARDED_FOR_HEADERS to the reverse-proxy config#2272
J0WI merged 2 commits intonextcloud:masterfrom
dgiebert:master

Conversation

@dgiebert
Copy link
Copy Markdown
Contributor

Needed for reverse proxy configuration to show the real IP (especially needed for helm nextcloud/helm#613)

Also defined here: https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/reverse_proxy_configuration.html#defining-trusted-proxies

Signed-off-by: Dominic Giebert <dominic.giebert@suse.com>
@jessebot
Copy link
Copy Markdown
Contributor

@dgiebert thank you for submitting this! I am not a maintainer on this repo, but wanted to gently ask if you could also include an update to one of these sections of the README:

This just makes it easier for future users to also use that env var you're adding :)

Signed-off-by: Dominic Giebert <dominic.giebert@suse.com>
@joshtrichards joshtrichards self-requested a review September 10, 2024 13:55
@joshtrichards joshtrichards added 3. to review Waiting for reviews feature: auto config (environment variables) Auto configuring via environment variables labels Sep 10, 2024
Copy link
Copy Markdown
Contributor

@J0WI J0WI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@J0WI J0WI merged commit a9f9885 into nextcloud:master Oct 8, 2024
@joshtrichards joshtrichards added this to the Nextcloud 30.0.1 milestone Oct 8, 2024
cuppett added a commit to cuppett/nextcloud-openshift-s2i that referenced this pull request Feb 16, 2026
)

Adds support for FORWARDED_FOR_HEADERS environment variable to configure
custom forwarded-for header names when behind reverse proxies. This is
useful when using non-standard headers like X-Real-IP or custom headers.

Co-authored-by: Dominic Giebert <dominicgiebert@outlook.com>
Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: auto config (environment variables) Auto configuring via environment variables

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants