fix(invite): Send invitation email independently of share creation#1510
Draft
fix(invite): Send invitation email independently of share creation#1510
Conversation
Previously, when inviting a guest from the files sharing dialog, the invitation email was suppressed (sendInvite was hardcoded to false) because the share notification email was expected to be sent on share save. This meant if the user didn't click "Save share", no email was ever sent. Added a checkbox to the guest form allowing users to control whether the invitation email is sent, defaulting to checked. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
requested review from
artonge,
leftybournes,
skjnldsv and
susnux
and removed request for
leftybournes
susnux
reviewed
Mar 19, 2026
|
|
||
| <!-- Send invite email --> | ||
| <div class="form-group"> | ||
| <NcCheckboxRadioSwitch :checked.sync="sendInvite" |
Contributor
There was a problem hiding this comment.
checked is deprecated, so switch to v-model to be future proof:
Suggested change
| <NcCheckboxRadioSwitch :checked.sync="sendInvite" | |
| <NcCheckboxRadioSwitch v-model="sendInvite" |
susnux
reviewed
Mar 19, 2026
| <!-- Send invite email --> | ||
| <div class="form-group"> | ||
| <NcCheckboxRadioSwitch :checked.sync="sendInvite" | ||
| :disabled="loading"> |
Contributor
There was a problem hiding this comment.
As this is a single switch an not a multi-select I think UX wise a switch is the proper type :)
Suggested change
| :disabled="loading"> | |
| :disabled="loading" | |
| type="switch"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when inviting a guest from the files sharing dialog, the invitation email was suppressed (sendInvite was hardcoded to false) because the share notification email was expected to be sent on share save. This meant if the user didn't click "Save share", no email was ever sent. Added a checkbox to the guest form allowing users to control whether the invitation email is sent, defaulting to true.