-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Cleanup middleware registering #12224
Copy link
Copy link
Closed
Labels
1. to developAccepted and waiting to be taken care ofAccepted and waiting to be taken care oftechnical debt🧱 🤔🚀🧱 🤔🚀
Milestone
Description
We register the middleware services in each and every DIContainer.
This is not really needed as the only place we query them is in:
server/lib/private/AppFramework/DependencyInjection/DIContainer.php
Lines 313 to 335 in 9319d55
| $this->registerService('MiddlewareDispatcher', function(SimpleContainer $c) use (&$middleWares) { | |
| $dispatcher = new MiddlewareDispatcher(); | |
| $dispatcher->registerMiddleware($c[OC\AppFramework\Middleware\Security\SameSiteCookieMiddleware::class]); | |
| $dispatcher->registerMiddleware($c['CORSMiddleware']); | |
| $dispatcher->registerMiddleware($c['OCSMiddleware']); | |
| $dispatcher->registerMiddleware($c['SecurityMiddleware']); | |
| $dispatcher->registerMiddleware($c[OC\AppFramework\Middleware\Security\PasswordConfirmationMiddleware::class]); | |
| $dispatcher->registerMiddleware($c['TwoFactorMiddleware']); | |
| $dispatcher->registerMiddleware($c['BruteForceMiddleware']); | |
| $dispatcher->registerMiddleware($c['RateLimitingMiddleware']); | |
| $dispatcher->registerMiddleware(new OC\AppFramework\Middleware\PublicShare\PublicShareMiddleware( | |
| $c['Request'], | |
| $c->query(ISession::class), | |
| $c->query(\OCP\IConfig::class) | |
| )); | |
| foreach($middleWares as $middleWare) { | |
| $dispatcher->registerMiddleware($c[$middleWare]); | |
| } | |
| $dispatcher->registerMiddleware($c['SessionMiddleware']); | |
| return $dispatcher; | |
| }); |
We can just properly query or register them there.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
1. to developAccepted and waiting to be taken care ofAccepted and waiting to be taken care oftechnical debt🧱 🤔🚀🧱 🤔🚀