[Bug]: Recent pages show shares with updated names

[max-nextcloud]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

If a share is renamed it will show with the new name in the recent pages lists for the recipients. Clicking the share will take you to the root of your files instead of the share itself.

Steps to reproduce

1. Share a file
2. Rename the file
3. Login as the recipient of the file
4. Look for the file in recent pages
5. See renamed file and attempt to open it

Expected behavior

To be consistent with the file list itself the recent file should show the name it has for the current user - not the owner.
Clicking the file to open it should work.

Installation method

Other Community project

Nextcloud Server version

27

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

None

Is this bug present after an update or on a fresh install?

Fresh Nextcloud Server install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

{
    "system": {
        "debug": true,
        "profiler": true,
        "apps_paths": [
            {
                "path": "\/var\/www\/html\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/www\/html\/apps-extra",
                "url": "\/apps-extra",
                "writable": false
            },
            {
                "path": "\/var\/www\/html\/apps-writable",
                "url": "\/apps-writable",
                "writable": true
            }
        ],
        "allow_local_remote_servers": true,
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "1025",
        "skeletondirectory": "\/skeleton",
        "loglevel": 2,
        "log_query": false,
        "query_log_file": "\/var\/www\/html\/data\/query.log",
        "diagnostics.logging": false,
        "diagnostics.logging.threshold": 0,
        "log.condition": {
            "apps": [
                "diagnostics",
                "admin_audit"
            ]
        },
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "localhost",
            "nextcloud",
            "nextcloud.local",
            "192.168.27.6",
            "localhost"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "27.1.0.0",
        "overwrite.cli.url": "https:\/\/nextcloud.local",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "updater.release.channel": "git",
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379
        },
        "memcache.local": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "overwriteprotocol": "https",
        "app_install_overwrite": [
            "collectives"
        ],
        "theme": "",
        "maintenance": false
    }
}

List of activated Apps

Enabled:
  - circles: 27.0.0
  - cloud_federation_api: 1.10.0
  - collectives: 2.7.0
  - comments: 1.17.0
  - contacts: 5.4.0-beta.1
  - contactsinteraction: 1.8.0
  - dashboard: 7.7.0
  - dav: 1.27.0
  - federatedfilesharing: 1.17.0
  - federation: 1.17.0
  - files: 1.22.0
  - files_reminders: 1.0.0
  - files_retention: 1.16.0
  - files_sharing: 1.19.0
  - files_trashbin: 1.17.0
  - files_versions: 1.20.0
  - lookup_server_connector: 1.15.0
  - oauth2: 1.15.1
  - provisioning_api: 1.17.0
  - settings: 1.9.0
  - sharebymail: 1.17.0
  - systemtags: 1.17.0
  - text: 3.8.0
  - theming: 2.2.0
  - twofactor_backupcodes: 1.16.0
  - updatenotification: 1.17.0
  - user_oidc: 1.3.3
  - user_status: 1.7.0
  - viewer: 2.1.0
  - weather_status: 1.7.0
  - workflowengine: 2.9.0
Disabled:
  - admin_audit: 1.17.0
  - encryption: 2.15.0
  - files_external: 1.19.0
  - testing: 1.17.0
  - user_ldap: 1.17.0

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

Using https://github.com/juliushaertl/nextcloud-docker-dev/

[max-nextcloud]

I suspected the files to vue rewrite to be the culprit but turns out this also happens on Nextcloud 25 and the response to
https://nextcloud.local/index.php/apps/files/api/v1/recent already includes the wrong information:

{
    "files": [
        {
            "id": 175,
            "parentId": 2,
            "mtime": 1692087871000,
            "name": "try sharing renamed",
            "permissions": 31,
            "mimetype": "httpd\/unix-directory",
            "size": 0,
            "type": "dir",
            "etag": "64db363f26ea3",
            "shareOwner": "admin",
            "mountType": "shared-root",
            "hasPreview": false,
            "path": "\/"
        }
    ]
}

[max-nextcloud]

server/apps/files/lib/Helper.php

Lines 145 to 152 in 240e8ab

	public static function formatFileInfo(FileInfo $i) {
	$entry = [];
	$entry['id'] = $i['fileid'];
	$entry['parentId'] = $i['parent'];
	$entry['mtime'] = $i['mtime'] * 1000;
	// only pick out the needed attributes
	$entry['name'] = $i->getName();

$i->getName(); on the last line will get the name from the storage root. This dates back to dea5219 and I think I've also seen it in Nextcloud 25.

[max-nextcloud]

This is fixed in stable28 by using another endpoint.

[max-nextcloud]

well... the ui does not expose the issue anymore - but the underlying problem is not fixed yet.