Skip to content

Move OC.AppConfig, OC.EventSource and OC.L10N to the server bundle#13878

Merged
MorrisJobke merged 3 commits intomasterfrom
refactor/oc-appconfig-eventsource-l10n
Jan 29, 2019
Merged

Move OC.AppConfig, OC.EventSource and OC.L10N to the server bundle#13878
MorrisJobke merged 3 commits intomasterfrom
refactor/oc-appconfig-eventsource-l10n

Conversation

@ChristophWurst
Copy link
Copy Markdown
Member

And another three requests less per page load 🚀

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Jan 29, 2019
@ChristophWurst ChristophWurst added this to the Nextcloud 16 milestone Jan 29, 2019
@ChristophWurst ChristophWurst self-assigned this Jan 29, 2019
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the refactor/oc-appconfig-eventsource-l10n branch from 27b55b4 to d0cd091 Compare January 29, 2019 08:39
Backbone,
ContactsMenu,
EventSource,
L10N,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

god I'm loving this <3
It's so beautiful I could cry 👀

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 💃 😹

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 29, 2019
@MorrisJobke
Copy link
Copy Markdown
Member

And another three requests less per page load 🚀

I was wondering why this is the case, but those files are only loaded when debug is set to true. Otherwise those files are already bundled 😉

@ChristophWurst
Copy link
Copy Markdown
Member Author

I was wondering why this is the case, but those files are only loaded when debug is set to true. Otherwise those files are already bundled wink

Psssst 😉

@ChristophWurst
Copy link
Copy Markdown
Member Author

But they relied on server-side bundling, hence always required the server to serve them when requested. With the webpack they are static and can be served by the webserver.

@rullzer
Copy link
Copy Markdown
Member

rullzer commented Jan 29, 2019

But they relied on server-side bundling, hence always required the server to serve them when requested. With the webpack they are static and can be served by the webserver.

Exactly. And this is something that should not be underestimated. The bundle here can be servered statically by any webserver. Proper caching gzip etc. While the other always needed to go to the storage when serving or at least setup the whole nextcloud php env to serve the file. And it is worse when a relatively slow stroage is used (objectstore requies http requests for example).

Long story short 🚀

@MorrisJobke
Copy link
Copy Markdown
Member

Sure - I didn't meant to made this worse than it is. Even if it just would mean that we properly organize our JS code it would be perfectly fine 👍

@MorrisJobke MorrisJobke merged commit 2682d67 into master Jan 29, 2019
@MorrisJobke MorrisJobke deleted the refactor/oc-appconfig-eventsource-l10n branch January 29, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants