Move OC.AppConfig, OC.EventSource and OC.L10N to the server bundle#13878
Move OC.AppConfig, OC.EventSource and OC.L10N to the server bundle#13878MorrisJobke merged 3 commits intomasterfrom
Conversation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
27b55b4 to
d0cd091
Compare
| Backbone, | ||
| ContactsMenu, | ||
| EventSource, | ||
| L10N, |
There was a problem hiding this comment.
god I'm loving this <3
It's so beautiful I could cry 👀
I was wondering why this is the case, but those files are only loaded when |
Psssst 😉 |
|
But they relied on server-side bundling, hence always required the server to serve them when requested. With the webpack they are static and can be served by the webserver. |
Exactly. And this is something that should not be underestimated. The bundle here can be servered statically by any webserver. Proper caching gzip etc. While the other always needed to go to the storage when serving or at least setup the whole nextcloud php env to serve the file. And it is worse when a relatively slow stroage is used (objectstore requies http requests for example). Long story short 🚀 |
|
Sure - I didn't meant to made this worse than it is. Even if it just would mean that we properly organize our JS code it would be perfectly fine 👍 |
And another three requests less per page load 🚀