Avoid allocating too much memory for the buffer on s3 uploads#34537
Merged
Avoid allocating too much memory for the buffer on s3 uploads#34537
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
added
bug
3. to review
Member
Author
juliusknorr
requested review from
a team,
icewind1991 and
skjnldsv
and removed request for
a team
Member
Author
|
/backport to stable25 |
Member
Author
|
/backport to stable24 |
juliusknorr
changed the title
skjnldsv
added
4. to release
This was referenced Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise we try to allocate ~500MB in memory which does fail on larger file uploads with our default memory limit. We only need the put file limit configured anyways.
Steps to reproduce on 24+:
Before that change the MOVE request ended in an Allowed Memory Size Exhausted error.