Better error messages for objectsack swift configuration#4112
Merged
icewind1991 merged 2 commits intomasterfrom Mar 28, 2017
Merged
Better error messages for objectsack swift configuration#4112icewind1991 merged 2 commits intomasterfrom
icewind1991 merged 2 commits intomasterfrom
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
|
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @butonic, @nickvergessen and @MorrisJobke to be potential reviewers. |
Member
|
Great! 👍 |
Codecov Report
@@ Coverage Diff @@
## master #4112 +/- ##
===========================================
- Coverage 54.23% 54.2% -0.03%
- Complexity 21278 21294 +16
===========================================
Files 1310 1310
Lines 81213 81253 +40
Branches 1285 1285
===========================================
+ Hits 44043 44045 +2
- Misses 37170 37208 +38
Continue to review full report at Codecov.
|
2 tasks
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
swift-config
branch
from
489c472 to
8dbca71
Compare
MorrisJobke
added
4. to release
This was referenced Sep 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
try to figure out specificly what's wrong with the config and try to give suggestions how to fix it instead of just throwing generic exceptions.