Adding Identity Provider#164
Merged
deiu merged 37 commits intonodeSolidServer:masterfrom Jan 12, 2016
Merged
Conversation
This is something that I too would like to understand better! I tried implementing some stuff like this recently and the only way I could figure to do it was to have the certificate request come from a different domain/provider. Let me know what you figure out 👍 |
Contributor
Author
|
Ok, when tested with linkeddata/node-webid#9 it works. However, we need to merge linkeddata/node-webid#9 and update the version of |
Closed
Contributor
There was a problem hiding this comment.
I wonder if we can add a test here to check if the user can login with the new cert -- i.e. get the same WebID from the User header, following an authenticated request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105
Ready to merge (only after linkeddata/node-webid#9 is merged and published on NPM)
This has been a lot more fun (and a lot more work!) than we thought.
Things left to do:
Things left to do in new PRs: