Legacy API of Agent.prototype.addRequest()

[vsemozhetbyt]

• Subsystem: http

Agent.prototype.addRequest() in the _http_agent.js checks for a Legacy API with a string type of the options parameter. However, this method called only with this call chain:

http.request() in http.js -> exports.ClientRequest() in _http_client.js -> Agent.prototype.addRequest() in the _http_agent.js.

On the ClientRequest() stage any string is converted to Object.

Is there any reason to keep this Legacy API check in the Agent.prototype.addRequest()? Is this function called from a userland or in any other way?

[vsemozhetbyt]

There are some agent subclasses using this today. Despite the addRequest function being undocumented internal API, it's easy enough to just support the old signature for backwards compatibility.

12cd133

Is this info still valid?

(It seems there is only one test with the legacy API)

[vsemozhetbyt]

I will close it as deleting the check does not give any performance gain according to my benchmarking anyway.