Missing assert from merge

[julianduque]

On node_module_register an assert is missing from 0.12.x

https://github.com/nodejs/node-v0.x-archive/blob/v0.12/src/node.cc#L1950-L1953

[bmeck]

This was discovered as we were checking addon compatibility and saw a segfault from trying to load a 0.12.7 version of fsevents against 4.0.0. The segfault occurs prior to the version mismatch message.

[cjihrig]

Is this still an issue? I tested with v4.0.0 and got the described segfault:

Segmentation fault: 11

However, I ran with master and got:

module.js:448
  return process.dlopen(module, path._makeLong(filename));
                 ^

Error: Module version mismatch. Expected 47, got 14.
    at Error (native)
    at Object.Module._extensions..node (module.js:448:18)
    at Module.load (module.js:354:32)
    at Function.Module._load (module.js:311:12)
    at Module.require (module.js:364:17)
    at require (module.js:383:17)
    at Object.<anonymous> (/private/tmp/foo.js:2:16)
    at Module._compile (module.js:423:26)
    at Object.Module._extensions..js (module.js:430:10)
    at Module.load (module.js:354:32)

[jasnell]

@cjihrig ... can you check 4.2.2?

[cjihrig]

With v4.2.2:

module.js:460
  return process.dlopen(module, path._makeLong(filename));
                 ^

Error: Module version mismatch. Expected 46, got 14.
    at Error (native)
    at Object.Module._extensions..node (module.js:460:18)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:311:12)
    at Module.require (module.js:366:17)
    at require (module.js:385:17)
    at Object.<anonymous> (/private/tmp/foo.js:2:16)
    at Module._compile (module.js:435:26)
    at Object.Module._extensions..js (module.js:442:10)
    at Module.load (module.js:356:32)

[jasnell]

So long as that's the expected error, if it's working in v4.2.x and master, I'd say it's resolved.

[cjihrig]

Seems as good as can be expected, and much better than a segfault. But I'll wait to hear from @julianduque or @bmeck

[cjihrig]

Haven't heard anything, and the situation seems to have improved. Closing.