Skip to content

src: guard default_inspector_port#12303

Closed
danbev wants to merge 1 commit intonodejs:masterfrom
danbev:guard-default_inspector_port
Closed

src: guard default_inspector_port#12303
danbev wants to merge 1 commit intonodejs:masterfrom
danbev:guard-default_inspector_port

Conversation

@danbev
Copy link
Contributor

@danbev danbev commented Apr 10, 2017

When configuring and building --without-ssl the following warning is
reported:

../src/node_debug_options.cc:12:11: warning: unused variable
'default_inspector_port' [-Wunused-const-variable]
const int default_inspector_port = 9229;

The commit adds a HAVE_INSPECTOR guard to this constant.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants