async_hooks: fix default nextTick triggerAsyncId#14026
Closed
AndreasMadsen wants to merge 4 commits intonodejs:masterfrom
AndreasMadsen:async-hooks-resource-null
Closed
async_hooks: fix default nextTick triggerAsyncId#14026AndreasMadsen wants to merge 4 commits intonodejs:masterfrom AndreasMadsen:async-hooks-resource-null
AndreasMadsen wants to merge 4 commits intonodejs:masterfrom
AndreasMadsen:async-hooks-resource-null
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
async_hooks
In the case where
triggerAsyncIdisnullit should default to thecurrent executionAsyncId. This worked but as a side-effect the resource
object was changed too.
This fix also makes the null check more strict. EmitInitS is not a
documented API, thus there is no reason to be flexible in its input.
/cc @nodejs/async_hooks