test: migrate fs read promises to test runner#55749
Open
Ceres6 wants to merge 1 commit intonodejs:mainfrom
Open
test: migrate fs read promises to test runner#55749Ceres6 wants to merge 1 commit intonodejs:mainfrom
Ceres6 wants to merge 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
needs-ci
bengl
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
avivkeller
reviewed
Nov 6, 2024
| const fsPromises = require('node:fs/promises'); | ||
| const read = require('node:util').promisify(fs.read); | ||
| const assert = require('node:assert'); | ||
| const { describe, test } = require('node:test'); |
Member
There was a problem hiding this comment.
Suggested change
| const { describe, test } = require('node:test'); | |
| const { describe, it } = require('node:test'); |
"it" is the correct function for "describe", but I don't remember if it really matters under the hood
Contributor
Author
There was a problem hiding this comment.
I think one is an alias of the other, but changed it anyway
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55749 +/- ##
==========================================
- Coverage 88.43% 88.40% -0.04%
==========================================
Files 654 654
Lines 187698 187747 +49
Branches 36123 36130 +7
==========================================
- Hits 165998 165973 -25
- Misses 14945 15012 +67
- Partials 6755 6762 +7
|
legendecas
added
request-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate
test/parallel/test-fs-read-promises-optional-paramsto use node test runner