loader: lazy-load source map cache in CJS loader#62267
Open
gurgunday wants to merge 1 commit intonodejs:mainfrom
Open
loader: lazy-load source map cache in CJS loader#62267gurgunday wants to merge 1 commit intonodejs:mainfrom
gurgunday wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62267 +/- ##
==========================================
- Coverage 89.68% 89.68% -0.01%
==========================================
Files 676 676
Lines 206495 206554 +59
Branches 39537 39549 +12
==========================================
+ Hits 185204 185243 +39
- Misses 13435 13450 +15
- Partials 7856 7861 +5
🚀 New features to boost your workflow:
|
H4ad
reviewed
Mar 15, 2026
| }; | ||
|
|
||
| const { BuiltinModule } = require('internal/bootstrap/realm'); | ||
| const { |
Member
There was a problem hiding this comment.
Usually when you lazy load like this, there's one test that fails if this file is not included anymore in the main path.
Did you run the tests locally? If not, try run this test and see if it fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why we're not lazy loading this? Seems like a good candidate