Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
That is a good question. I will write up the guidelines for Official vs Community on a follow-up PR and how to get your installation method or package manager added to the current Downloads page. However, regarding official versus community, I'd say there needs to be some criteria for the official status to be attained. (Keep in mind these are criteria I've come up with and were NOT agreed upon yet; these are pending discussion and agreement)
fnm may already fit the criteria. Still, at the moment, I only marked (intentionally) "nvm" as the only Official one as it already fits all these criteria above, and it is the most used version manager out there. I'm more than happy adding "fnm" to the list, I don't even know who the fnm maintainers are and if they have any ties with the Node project. |
This comment was marked as resolved.
This comment was marked as resolved.
chore: removed all translated (old) downloads page (forcing re-translation) fix: fix build and extension extraction chore: just update todo text Apply suggestions from code review Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com> Signed-off-by: Claudio W <cwunder@gnome.org> fix: fixed unit tests chore: unnecessary memoization of reqs chore: some minor code review changes feat: code review and iteration on logic chore: improvements for docker chore: more improvements for texts and sizes chore: minor design updates chore: numerous improvements and fixes chore: some typo fixes feat: bug fixes, improved types, handle unknown scenarios and fallback chore: always use corepack to enable pnpm chore: util will always return string, but `parseNumericBitness` ensures number is set chore: improved types chore: random changed file chore: some code reviews and bug fixes chore: not an external link
1e75d11 to
abe2da4
Compare
|
Lighthouse Results
|
ljharb
left a comment
There was a problem hiding this comment.
i'm happy with the current state of the PR, thanks!
Co-authored-by: Jordan Harband <ljharb@gmail.com> Signed-off-by: Claudio W <cwunder@gnome.org>
|
Cane someone from @nodejs/web-infra approve this PR too? |
MattIPv4
left a comment
There was a problem hiding this comment.
LGTM.
Looking forward to the follow-up docs PR for folks wanting to add other community options, and what constitutes an official option vs. community.
As a future improvement, would love the over-the-wire HTML to have some default selected (perhaps based on stats for the most common OS) and the snippet pre-rendered (could just be plain-text if Shiki pre-rendering is too complex).
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Yah indeed, if JS isn't available and before JS has run on the page but once the HTML has arrived (with my slow:tm: internet, I see a solid few seconds of the empty code block which I'd love to see have a default of some sort loaded instead from the start) |
I tested with slow 3g and it took 2-3 seconds, but honestly that shouldn't be a concern. The issue of having an initial codebox regardless of environment, @MattIPv4 is that it will cause a flash effect, since most likely it will show a different one once it renders, hence why the Skeleton. It would also require Shiki + Eval'ing the snippet to happen twice. My last commit was done as a performance pass meticulously 👀 the performance graphs on DevTools. |
This PR introduces the shiny new Downloads page envisioned by the package maintenance Working Group (#7037).
It also officially unblocks community members from adding package managers and installation methods to the Downloads page!
Warning!: This PR also resets all translations for the downloads page (unfortunately, as a preventive method)
Closes #7037
Closes #7296
Unblocks #6953
Unblocks #6978
Unblocks #6832
CHECK THE PREVIEW HERE