fix(timeline-helper-wrapper): Fix return value in timeline wrapper for promises#567
Merged
fix(timeline-helper-wrapper): Fix return value in timeline wrapper for promises#567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes bug of usage
timelineoption withuseAsyncDatawithlazy: trueType of change
Description
Case if bug:
useAsyncDatareturns only promise, without data, pending and othersReproduction
./playgrounds/empty(JFI - it only works on local machine, in stackblitz timeline metrics can't be enabled)useAsyncData()return not only promise, it also return a lot additional attributes, likedata,pending,error, example:useAsyncData()with metrics wrapper returning value is only promise, example with timeline enabled:timeline: { enabled: true } }all working as expectedThis happens, because
.finally()returns only Promise, without additional attributes, added byuseAsyncData()Looking for feedback about fix :)