Fixes to union properties#241
Merged
dbanty merged 6 commits intoopenapi-generators:mainfrom Nov 18, 2020
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transforms oninner_propertys of theUnionPropertytransformon all templates to take in adeclare_typekwarg (defaultTrue) that determines if the first declaration of the property should include typedefunion_property.pyi'stransformto prevent mypy issues when calling thetransformof itsinner_propertiesconstructon all templates to take ainitial_valuekwarg (defaults as appropriate, usuallyNone,[]for lists)union_property.pyi'sconstructto prevent invalidly assigningNoneto theinner_property_parse_<inner_property>function inunion_property'sconstructto use the passed subresource instead of the top level dict from the outer scope