Skip to content

Get rid of Artifactory dependency#466

Draft
TomTasche wants to merge 7 commits intomainfrom
kill-artifactory
Draft

Get rid of Artifactory dependency#466
TomTasche wants to merge 7 commits intomainfrom
kill-artifactory

Conversation

@TomTasche
Copy link
Copy Markdown
Member

@TomTasche TomTasche mentioned this pull request Mar 31, 2026
Comment on lines +1 to +3
[submodule "OpenDocument.core"]
path = OpenDocument.core
url = https://github.com/opendocument-app/OpenDocument.core
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should rather depend on https://github.com/opendocument-app/conan-odr-index so versions make sense. updates can be automated with renovate

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, but by the time you mentioned this idea earlier today I had it all implemented already. also, I hope I can leverage that core submodule in other ways in the future, i.e. reusing latest test documents in an automated fashion... or maybe I'm dreaming!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right but that can also be achieved by getting the test repo as submoulde

depending directly on the core means that the directory structure couples which adds another thing that can break

we would still need to bump the submodule to core to make an update but lose the version number. does not really seem worth to me. but your call on the platform side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants